-
Posts
976 -
Joined
-
Last visited
Everything posted by Scooby
-
np, we all make easy mistakes once in a while
-
the command is !inc, not %inc. mirc thinks ur trying to set %inc to all these variables
-
line 23 and 40, at a glance, u have: if (ALIVE isin $current.status) { maybe the line should read: if (ALIVE isin $current.status($1,$2)) { i can see ur using isin too, im just not sure why ur not using == ok, ive just noticed a lot of ur identifiers like this one above, ur not sending the parameters > ($1,$2), im guessing they wont be working properly either.
-
in previous scripts ive made, using 'alises' to reduce the size of the mta.command alias has reduced the speed dramatically. i was told years ago that mirc parses the aliases on start but ive been unable to clarify if this is true. of course the aliases from the signals are pointless and would slow the script(when i say slow down, this is so tiny u wouldnt notice it) but the commands can be written directly to the signals. some things in scripts will speed them up a lot, also, some are such a minute difference that u wouldnt notice it over 1 line, but as a whole, its best to do all u can to make it run as fast as possible. most of us dont do this in general scripts because of laziness, but theres usually always room to improve scripts, i would recommend u keep ur aliases, but lose the ones that are unneeded.
-
u will need to add the { }'s for it to work if u add it all between an external set of brackets(some people dont use the external ones) also, u need to ask each one individually, elseif (($5 != 1) || ($5 != 2) || ($5 != 3) || and so on) or u could do: elseif (($5 < 1) || ($5 > 10) && ($5 != 1337)) { if its just to see if someone has admin, elseif ($5 != 0) would be the best way.
-
the alias was something written years ago, theres many ways to do this, this might not be too accurate... just take out the banned word alias, it shouldnt be too hard to edit the text and change the line to mute someone. something like this: alias pgs.bannedwords { var %a = 1,%b = $3-,%c = $lines(pgs.banwords.txt) while (%a <= %c) { if ($read(pgs.banwords.txt,%a) isin %b) { mta.pm $1 $2 Auto-Muted: 60 secs - Reason: Vulgarity mta.mute $1 $2 .timer 1 60 mta.unmute $1 $2 !halt } !inc %a } } theres a few commands that add/remove words that u will need to take out too, im sure u can find them. i think lil toady posted a banwords script on the forum, u might be better finding that one out, it might be a bit more like what ur looking for.
-
one or two i guess, mta.finish seemed to work better for me than mta.endrace, not sure how it is nowdyays. i still use mta.finish. i know thats not in my scripting.html list, also, mta.respawn. not sure if theres any others tho. Havent had time to look thru the entire script yet, looks like u seem to know what ur doing tho. u might want to add an extra line or 2 to do some more checks on some of the admin commands, like !ban, u might want to add a few user friendly lines also make it so u cant accidentally ban yourself. the usual format would check admin level, check if id is you/them/unknown, then do the command. giving off the relevant error msgs if needed. if i get time later i'll take a look at ur script in more detail.
-
well within 30 secs of scrolling down ur script i spotted over 20 errors/mistakes/bugs... whatever u want to call them. i wont bother letting u know anymore tho, coz it seems theyve been there for 4 releases now... and i take it u arent gonna fix them, but thats up to u. if u want people to look at ur script and laugh at all the BASIC mistakes uve made, well then i guess thats up to you. I find it hard to believe u wrote all of this script, since there are some more complicated things in it that look ok, yet u cant even get the basics right.
-
u didnt fix any of the errors...
-
At a glance i can see a lot of if/elseif/else errors, i think u should go through it and fix them or people will be seeing lots of errors/bugs.
-
sanzor, you know... ur script still is full of bugs/errors. are you not going to fix it??? gj on the script Bart, im sure in time people will use what they like from it, most people want to alter a few things here and there. but just give it time i guess. they use it or they dont... no need to worry about it
-
the size of the script doesnt alter the response time that much the way its written since all of ur commands are aliased. i havent checked it but u can always try looking in task manager to see the cpu usage its using. looking at it i doubt its using over 10% (bet to test on start/end of a race with as many players as poss) for me, GUS was using 15% to 25% and noone seemed to complain much then. i think from when i last looked the only thing that could slow it down a lot is if u have loads of new commands added with ur add command script, since the commands are added to an ini, which has to be searched on every command. (u could move it to the end of the alias or try hashing it if u havent already) failing that it didnt look to bad to me. but then again... do u really want to take the word of such a skilled scripter like lil san? just check for yourself
-
hehe like i said... debatable
-
lol.. i bet accurate.. hmm well im sure it doesnt need to be to the nearest second, i have mine as mins/hours/weeks/days/months every 60 secs it checks the file for names to be unbanned. both are as good i guess, its just if people used it a lot they could end up with a lot of timers running, rather than just 1. anyway its all good i guess.
-
well u can practice in VC with toadys lua conversion, thats why i got u to download VC
-
hehehe... looks kinda big lil toady... ur slacking mate.. u should have use a multiplier for the d/h/m then u wouldnt have needed the same code 3 times. also, 1 timer running a check on the banned people might be better than a timer per person, although i guess thats debatable. good work all the same. foo, I havent tried it, but maybe u should have tried it before u took stuff out. now noone knows if its broke because of what uve changed.
-
Sadly i figured it out all too late, i dont see the point in making new stuff now. im sure DM will be out soon (no idea when) but then most, if not all these race scripts will be obsolete. i dont see the point spending hours making new stuff when time could be spent practicing the same stuff in lua.
-
muhahhaa now if i just told u, where would all the fun be in that... everything u need can be found in mirc > help tho.
-
u can do it in normal irc script, no need for php/sql or any external scripts.
-
its possible and not too hard to script, the setting up is a little more tricky tho. since u need a few extra files. proabably no advisable as a release unless with an installer or a lot of documentation though.
-
Not possible.. these kinds of things are not added into MTA so its impossible to script them. Dont u think we would have included stuff like this long ago if it was
-
u should only need to put the script in the main mirc dir, wherever u have it. load it up and it should work fine. all the hash txt files will be saved to that folder too.
-
why dont u write YOUR OWN.... from scratch.... without copying someone elses! i mean in ur script it says... ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; GUSMS V1.2 By: SanZoR ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ; If you use this script, you are not allowed to sell or take parts of it to your own script ; ;;;;;;;;;;;;;;;;;;; Please dont edit my name anywhere in this script ;;;;;;;;;;;;;;;;;;;;;;;;; yet u take other peoples.... nowhere in ur script does it give credit to them.
-
yeah id suggest that too.. i just couldnt be bothered to write it off my head. ive figured out how to do so much cool stuff just lately, like a proper login system for ALL users, for mta race, uploading server info to a website etc, all with only a normal irc script. i just cant be bothered to make it now... is it really worth it roll on DM!
