addEventHandler("onMoneyChange",..

[BriGhtx3]

Is it possible to create something that when the amount of money changes, it automaticly saves it?

I know that I can use a timer, but I mean sth like a handler

[GanJaRuleZ]

Well you can make for yourself too ..

Here are is my suggestion :

onClientRender 

You use this as a event handler , for the function , and you must script that everytime it saves the amount of the money

[Thelastride]

Here

function DXdraw() 
sWidth, sHeight = guiGetScreenSize() 
dxDrawText("Money "..tostring (getPlayerMoney(getLocalPlayer()),40,40,sWidth,sHeight,tocolor(0,255,0,255),1.5,"pricedown","right","top",false,false,false) 
end 
addEventHandler("onClientRender", getRootElement(), DXdraw) 

[BriGhtx3]

Hmm alright, would be nice if there was a single Handler but ok

Thanks

[BriGhtx3]

New problem :

I'm trying to show the players country but it always returns false.

function setLand() 
    local flag = exports['admin']:getPlayerCountry ( source ) 
    outputChatBox(tostring(flag)) 
    if flag then 
        setElementData(source,"Land",":admin/client/images/flags/"..flag..".png") 
    else 
        setElementData(source,"Land","N/A") 
    end 
end 
addEventHandler("onPlayerJoin",getRootElement(), setLand) 

The country is always set to N/A. I'm living in Germany

[CapY]

You need to edit SCOREBOARD resource for that.

[BriGhtx3]

I already did it, but it never worked.

Edited line 705 added if column.name....

But it still doesn't show it, neither put out the country.

[BinSlayer1]

Money doesn't change out of the blue..

Money only changes when you tell the script to use setPlayerMoney, givePlayerMoney or takePlayerMoney

Everytime you use either of those functions, launch your own custom event "onMoneyChange", eventually passing the current money or whatever you like as parameters.

use triggerEvent()

https://wiki.multitheftauto.com/wiki/TriggerEvent

E.g: In case you use givePlayerMoney(player, 300), do this afterwards: triggerEvent ('onMoneyChange', player, getPlayerMoney(player))

PS: You can scrap passing getPlayerMoney, I'm just showing an example

[Castillo]

local oldMoney = getPlayerMoney() 
  
function renderMoney() 
    newMoney = getPlayerMoney() 
    if ( tonumber(newMoney) ~= tonumber(oldMoney) ) then 
         triggerEvent("onClientMoneyChange",localPlayer,oldMoney,newMoney) 
         oldMoney = newMoney 
    end 
end 
addEventHandler("onClientRender",root,renderMoney) 
  
addEvent("onClientMoneyChange",true) 
addEventHandler("onClientMoneyChange",root, 
function (old, new) 
    outputChatBox(tostring(old) ..": ".. tostring(new)) 
end) 

Seems to work just fine.

[codeluaeveryday]

Solidsnake just created the onMoneyChange event handler Great job, is it ok if I implement this in one of my scripts?

[Castillo]

Sure, if it works without any problem, then I see no problem on someone using it.

[Kenix]

Client

addEvent( "onClientMoneyChange",true ) 
  
addEventHandler( "onClientMoneyChange",root, 
    function( oldMoney,newMoney ) 
        -- .... 
    end 
) 
     
function _givePlayerMoney( ... ) 
    local args = { ... } 
    if type( args[1] ) == "number" then 
        if triggerEvent( "onClientMoneyChange",localPlayer,getPlayerMoney( ),args[1] ) and 
        givePlayerMoney( ... ) then 
            return true 
        end 
        return false     
    end 
end 

Edited January 12, 2012 by Guest

[BinSlayer1]

@Kenix: It's pretty wrong to use clientside functions to alter the money

While it's okay to getPlayerMoney clientside, it's not a good idea to givePlayerMoney

[Thelastride]

Yes givePlayerMoney client side will give fake money because most of scripts use getPlayerMoney serverside.

[Kenix]

This is example with client side.

Server

addEvent( "onMoneyChange",true ) 
  
addEventHandler( "onMoneyChange",root, 
    function( oldMoney,newMoney ) 
        -- .... 
    end 
) 
     
function _givePlayerMoney( ... ) 
    local args = { ... } 
    if isElement( args[1] ) and type( args[2] ) == "number" then 
        if triggerEvent( "onMoneyChange",args[1],getPlayerMoney( args[1] ),args[2] ) and 
        givePlayerMoney( ... )  
        then 
            return true 
        end 
        return false 
    end 
end 

[Scooby]

Solidsnake, just out of curiosity, why did u add this line?

if (oldMoney < newMoney) then 

surely with that it only works if old money is less.. what if they have more?

shouldnt the function be:

function renderMoney() 
    newMoney = getPlayerMoney() 
    if ( tonumber(newMoney) ~= tonumber(oldMoney) ) then 
          triggerEvent("onClientMoneyChange",localPlayer,oldMoney,newMoney) 
          oldMoney = newMoney 
    end 
end 
addEventHandler("onClientRender",root,renderMoney) 

no offence intended... u do a great job on the forums helping people.

[BriGhtx3]

this problem is already solved, the scoreboard thing is the problem oO

[Castillo]

Solidsnake, just out of curiosity, why did u add this line?

if (oldMoney < newMoney) then 

surely with that it only works if old money is less.. what if they have more?

shouldnt the function be:

function renderMoney() 
    newMoney = getPlayerMoney() 
    if ( tonumber(newMoney) ~= tonumber(oldMoney) ) then 
          triggerEvent("onClientMoneyChange",localPlayer,oldMoney,newMoney) 
          oldMoney = newMoney 
    end 
end 
addEventHandler("onClientRender",root,renderMoney) 

no offence intended... u do a great job on the forums helping people.

Yup, it was a mistake, this was part of one of my HUD system's, I guess it was intended to do something for the HUD

Thanks for finding it out.

Corrected the script.

[Scooby]

no worries, i was just having a quick read through and noticed it.