removeEventHandler Issue

[Mann56]

Hello guys,

I've been making a script where i am outputting text on user's click, but it doesn't seem to fade away after timer does it's job. Any help?

  
function addVehScreenInfo ( button, state, absoluteX, absoluteY, worldX, worldY, worldZ, clickedElement ) 
        if ( clickedElement ) then 
                local elementType = getElementType ( clickedElement ) 
                if elementType == "vehicle" then 
                     
                    local occupants = getVehicleOccupants(clickedElement) 
                    function drawtheScene() 
                        dxDrawRectangle(absoluteX-15,absoluteY-20,300,100,tocolor(0,0,0,75),false)  
                        dxDrawText(getVehicleName(clickedElement),absoluteX,absoluteY,300,20,tocolor(255,255,255,255),sx*0.7,"bankgothic") 
                        dxDrawText("Driver : " ..getPlayerName(occupants[0]).."",absoluteX,absoluteY+20,300,20,tocolor(255,255,255,255),sx*0.7,"bankgothic") 
                    end 
                    addEventHandler("onClientRender",root,drawtheScene) 
                    setTimer ( stopVehRender,2000, 1) 
                end 
        end 
end 
addEventHandler ( "onClientClick", getRootElement(), addVehScreenInfo ) 
  
function stopVehRender() 
    removeEventHandler("onClientRender",root,drawtheScene) 
end 
  

[Bonus]

Why do you create the function drawtheScene in the function?

Don't do that ...

[Mann56]

But dude, the function won't work if outside i have some args in it that won't work outside it's parent function. I already tried it.

[KariiiM]

function addVehScreenInfo ( button, state, absoluteX, absoluteY, worldX, worldY, worldZ, clickedElement ) 
        if ( clickedElement ) then 
                local elementType = getElementType ( clickedElement ) 
                if elementType == "vehicle" then 
                    
                    local occupants = getVehicleOccupants(clickedElement) 
                    function drawtheScene() 
                        dxDrawRectangle(absoluteX-15,absoluteY-20,300,100,tocolor(0,0,0,75),false) 
                        dxDrawText(getVehicleName(clickedElement),absoluteX,absoluteY,300,20,tocolor(255,255,255,255),sx*0.7,"bankgothic") 
                        dxDrawText("Driver : " ..getPlayerName(occupants[0]).."",absoluteX,absoluteY+20,300,20,tocolor(255,255,255,255),sx*0.7,"bankgothic") 
                    end 
                    addEventHandler("onClientRender",root,drawtheScene) 
                    setTimer(function() removeEventHandler("onClientRender", root, drawtheScene) end, 2000, 1) 
                end 
        end 
end 
addEventHandler ( "onClientClick", getRootElement(), addVehScreenInfo ) 

[Mann56]

It still doesn't work, after 2 secs the rectangle just gets somewhat lighter, doesn't go off....

i did that before too, after that i put the remove event handler out

[KariiiM]

It still doesn't work, after 2 secs the rectangle just gets somewhat lighter, doesn't go off....

i did that before too, after that i put the remove event handler out

Any error/warning?

[Mann56]

Nothing ....

[KariiiM]

Nothing ....

Well obviously your code is incorrect, I will try to re script it for you

[Mann56]

Nothing ....

Well obviously your code is incorrect, I will try to re script it for you

A'ight , i just can't find the error since 2 hours

[KariiiM]

I had sent you the code via pm, check it and tell me the result (not tested)

[KariiiM]

I saw your pm, try this

local clickedElement = nil  
local absoluteX = nil  
local absoluteY = nil  
  
function addVehScreenInfo (button, state, absX, absY, wx, wy, wz, element) 
    if element and getElementType(element) == "vehicle" then 
        clickedElement = element 
        absoluteX = absX 
        absoluteY = absY 
        removeEventHandler("onClientRender",root,drawtheScene) 
        addEventHandler("onClientRender",root,drawtheScene) 
        setTimer(function() removeEventHandler("onClientRender", root, drawtheScene) end, 2000, 1) 
    end 
end 
addEventHandler ("onClientClick", getRootElement(), addVehScreenInfo,true) 
  
function drawtheScene() 
    dxDrawRectangle(absoluteX-15,absoluteY-20,300,100,tocolor(0,0,0,75),false) 
   dxDrawText(getVehicleName(clickedElement),absoluteX,absoluteY,300,20,tocolor(255,255,255,255),sx*0.7,"bankgothic") 
    dxDrawText("Driver : " ..getPlayerName(getVehicleOccupants(clickedElement)[0]).."",absoluteX,absoluteY+20,300,20,tocolor(255,255,255,255),sx*0.7,"bankgothic") 
end 

[Mann56]

Working great, thanks buddy!!

[KariiiM]

Working great, thanks buddy!!

You're welcome