Why is this not working?

[PARKAH]

marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function() 
    local vh = getPedOccupiedVehicle ( source ) 
    vehicles = {462} 
    nm = tonumber ( math.random( #vehicles ) ) 
    setElementModel ( vh, nm )   
end) 

[Baseplate]

marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function(hitElement) 
    local vh = getPedOccupiedVehicle (hitElement) 
    vehicles = {462} 
    nm = tonumber ( math.random( #vehicles ) ) 
    setElementModel ( vh, nm )   
end) 

The source of onClientMarkerHit is the maker itself, use hitElement instead.

[PARKAH]

Didn't work

[WASSIm.]

trailers = { 
    [606] = true, 
    [607] = true, 
    [610] = true, 
    [590] = true, 
    [569] = true, 
    [611] = true, 
    [584] = true, 
    [608] = true, 
    [435] = true, 
    [450] = true, 
    [591] = true 
} 
  
local marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function(thePlayer) 
    local vh = getPedOccupiedVehicle (thePlayer) 
    nm = math.random(400,602 ) 
    if (nm ~= trailers) then 
        setElementModel ( vh, nm )   
    end 
end) 

[PARKAH]

Urm what?

[xXMADEXx]

trailers = { 
    [606] = true, 
    [607] = true, 
    [610] = true, 
    [590] = true, 
    [569] = true, 
    [611] = true, 
    [584] = true, 
    [608] = true, 
    [435] = true, 
    [450] = true, 
    [591] = true 
} 
  
local marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function(thePlayer) 
    local vh = getPedOccupiedVehicle (thePlayer) 
    nm = math.random(400,602 ) 
    if (nm ~= trailers) then 
        setElementModel ( vh, nm )   
    end 
end) 

Huh?

@PARKAH - Do you have a "vehicles" table defined?

[manve1]

xXMADEXx, he does.

marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function() 
    local vh = getPedOccupiedVehicle ( source ) 
    vehicles = {462} -- RIGHT HERE HE DOES. 
    nm = tonumber ( math.random( #vehicles ) ) 
    setElementModel ( vh, nm )   
end) 

[xXMADEXx]

xXMADEXx, he does.

marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function() 
    local vh = getPedOccupiedVehicle ( source ) 
    vehicles = {462} -- RIGHT HERE HE DOES. 
    nm = tonumber ( math.random( #vehicles ) ) 
    setElementModel ( vh, nm )   
end) 

Oh, my bad. I didn't see that.

((Not Tested))

marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function( p ) 
    local vh = getPedOccupiedVehicle ( p ) 
    vehicles = {462} 
    nm = tonumber ( vehicles  [ math.random( #vehicles ) ] ) 
    setElementModel ( vh, nm )   
end) 

[PARKAH]

Didn't work

[iMr.3a[Z]eF]

Use localPlayer instead p or source

marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
addEventHandler("onClientMarkerHit",marker, 
function ( ) 
    local vh = getPedOccupiedVehicle ( localPlayer ) 
    if getElementModel(vh) == 462 then 
    local nm = tonumber ( vehicles  [ math.random( #vehicles ) ] ) 
    setElementModel ( vh, nm )   
    end 
end) 

[denny199]

You guys are all failing..

For vehicle id's you can look right here:

https://wiki.multitheftauto.com/wiki/Vehicle_IDs

  
local vehiclesTable = {429, 411, 541, 559, 415, 561, 480, 560, 562, 506, 565, 451, 434, 558, 494, 555, 502, 477, 503} 
  
marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
function markerHit(hitElement) 
if hitElement == localPlayer then 
    local vh = getPedOccupiedVehicle ( hitElement ) 
    local nm = tonumber (1,math.random( #vehiclesTable ) ) 
    setElementModel ( vh, nm )   
end 
end 
addEventHandler("onClientMarkerHit",marker,markerHit ) 
  

Tip:

Also aligain the vehicle posZ one cordinate up for preventing the cars to get stuck into the ground.

[PARKAH]

@denny

I only want it to spawn in one vehicle, so you're failing.

[denny199]

Whythehex are you using a table then, maybe because you got it from a another topic?

So please, tell us why are you using usseless tables, since i tought, a table with one vehicleID, so weird.

marker = createMarker(1949, -1705, 13,"corona",2,0,255,0) 
  
function markerHit(hitElement) 
if hitElement == localPlayer then 
    local vh = getPedOccupiedVehicle ( hitElement ) 
    setElementModel ( vh, 462)   
end 
end 
addEventHandler("onClientMarkerHit",marker,markerHit ) 

[TAPL]

setElementModel client side won't change the model for everyone, so that you know.

[PARKAH]

I got it from a tutorial topic, but none of those are working

[denny199]

Show us your meta...

[PARKAH]

The skin doesn't matter because it loads fine just doesn't work, it loads a green glow but it doesn't do anything.

[PARKAH]

bump

[xXMADEXx]

use attachElements?

[denny199]

Show us your meta.xml...

...