[HELP] problem

[K4stic]

addEventHandler("onMarkerHit", finish, 
function (thePlayer) 
    if ( getElementType ( thePlayer)) == "player" then 
        local fishes = getElementData( thePlayer, "fishes") 
        outputChatBox ( "You have sold "..fishes.." fishes and earned #00FF00$"..fishes * 3,thePlayer) 
        givePlayerMoney ( thePlayer,fishes* 3 ) 
        setElementData ( thePlayer, "fishes", 0, false) 
    end 
end 
) 

it's output me error => server.lua:5: attempt to concatenate local 'fishes' (a boolean value)

[Alexs]

Maybe the player haven't fishes.

addEventHandler("onMarkerHit", finish, 
function (thePlayer) 
    if ( getElementType ( thePlayer)) == "player" then 
        local fishes = getElementData( thePlayer, "fishes") or 0 
        outputChatBox ( "You have sold "..fishes.." fishes and earned #00FF00$"..fishes * 3,thePlayer) 
        givePlayerMoney ( thePlayer,fishes* 3 ) 
        setElementData ( thePlayer, "fishes", 0, false) 
    end 
end 
) 

[K4stic]

thx Alexs_Steel that part work

Now new problem

--client side

function getheVehicleSpeed() 
    return (x^2 + y^2 + z^2) ^ 0.5 
end 
  
addEvent ("enableFishermanMission",true) 
addEventHandler ("enableFishermanMission",getRootElement(), 
function() 
    if (source == getLocalPlayer()) then 
        addEventHandler ("onClientRender",getRootElement(),FishermanGUIText) 
    end 
    checkfishesbleh = setTimer( 
    function() 
        kmh = math.floor( getheVehicleSpeed( getPedOccupiedVehicle(getLocalPlayer()), getElementVelocity (getPedOccupiedVehicle(getLocalPlayer())) ) * 100 * 1.61 ) 
        curfish = getElementData(getPedOccupiedVehicle(getLocalPlayer()),"fishes") 
        if curfish > 499 then 
            setElementData(getPedOccupiedVehicle(getLocalPlayer()),"fishes",500) 
        else 
            if kmh >= 20 then 
                setElementData(getPedOccupiedVehicle(getLocalPlayer()),"fishes",curfish + math.random(1,4)) 
            end 
        end 
    end 
    ,5000,0) 
end 
) 

No error's just it not give fishes

Edited January 6, 2013 by Guest

[abu5lf]

thx Alexs_Steel that part work

Now new problem

--client side

function getheVehicleSpeed() 
    return (x^2 + y^2 + z^2) ^ 0.5 
end 
  
addEvent ("enableFishermanMission",true) 
addEventHandler ("enableFishermanMission",getRootElement(), 
function() 
    if (source == getLocalPlayer()) then 
        addEventHandler ("onClientRender",getRootElement(),FishermanGUIText) 
    end 
    checkfishesbleh = setTimer( 
    function() 
        kmh = math.floor( getheVehicleSpeed( getPedOccupiedVehicle(getLocalPlayer()), getElementVelocity (getPedOccupiedVehicle(getLocalPlayer())) ) * 100 * 1.61 ) 
        curfish = getElementData(getPedOccupiedVehicle(getLocalPlayer()),"fishes") 
        if curfish > 499 then 
            setElementData(getPedOccupiedVehicle(getLocalPlayer()),"fishes",500) 
        else 
            if kmh >= 20 then 
                setElementData(getPedOccupiedVehicle(getLocalPlayer()),"fishes",curfish + math.random(1,4)) 
            end 
        end 
    end 
    ,5000,0) 
end 
) 
) 

No error's just it not give fishes

You have a '(' extra, and 'getheVehicleSpeed' There are no argument.

Edited January 6, 2013 by Guest

[K4stic]

don't see it

and sorry i make wrong code is with one ')' but who i have say is no give fish

[abu5lf]

function getElementSpeed(element,unit) 
    if (unit == nil) then unit = 0 end 
    if (isElement(element)) then 
        local x,y,z = getElementVelocity(element) 
        if (unit=="mph" or unit==1 or unit =='1') then 
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
        else 
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.61 * 100 
        end 
    else 
        outputDebugString("Not an element. Can't get speed") 
        return false 
    end 
end 
  
addEvent( 'enableFishermanMission', true ) 
addEventHandler( 'enableFishermanMission', getRootElement( ), 
    function( ) 
        if ( source == localPlayer ) then 
            addEventHandler( 'onClientRender', getRootElement( ), FishermanGUIText ) 
            Timer = setTimer( checkfishesbleh, 5000, 0 ) 
        end 
    end 
) 
  
function checkfishesbleh( ) 
    local vehicle = getPedOccupiedVehicle( localPlayer ) 
    if ( vehicle ) then 
    local aSpeed = getElementSpeed( vehicle, 'kph' ) 
    local curfish = getElementData( vehicle, 'fishes' ) or 0 
        if ( curfish > 499 ) then 
            setElementData( vehicle, 'fishes', 500 ) 
        else 
            if ( aSpeed >= 20 ) then 
                setElementData( vehicle, 'fishes', ( curfish + math.random( 4 ) ) ) 
            end 
        end 
    end 
end 

Try This, not tested.

[K4stic]

same problem not give a fish and no error's

[abu5lf]

same problem not give a fish and no error's

Show your trigger ''enableFishermanMission'' .

[K4stic]

--Server side

local index,theBoat; 
  
for index,theBoat in ipairs ( getElementsByType ( "vehicle" ) ) do 
if ( model == 453 ) then 
    setElementData(theBoat, "fishboat", true) 
    setElementData(theBoat, "fishes", 0) 
 end 
end 
  
finish = createMarker( 971.8, -2103.6, 2.2,"cylinder", 2, 0, 0, 255, 155) 
FishingMinigameBlip = createBlipAttachedTo ( finish, 9, 2, 0, 0, 255, 255, 0, 250, getRootElement() ) 
  
addEventHandler("onMarkerHit", finish, 
function (thePlayer) 
    if ( getElementType ( thePlayer)) == "player" then 
        local fishes = getElementData( thePlayer, "fishes") or 0 
        outputChatBox ( "You have sold "..fishes.." fishes and earned $"..fishes * 3,thePlayer) 
        givePlayerMoney ( thePlayer,fishes* 3 ) 
        setElementData ( thePlayer, "fishes", 0, false) 
    end 
end 
) 
  
addEventHandler ( "onVehicleEnter", getRootElement(), 
function(thePlayer) 
    if getElementData(getPedOccupiedVehicle(thePlayer),"fishboat") then 
        triggerClientEvent(thePlayer, "enableFishermanMission",thePlayer) 
    end 
end 
) 
  
  
addEventHandler ( "onVehicleExit", getRootElement(), 
function(thePlayer) 
    if getElementData(source,"fishboat") then 
        triggerClientEvent(thePlayer, "disableFishermanMission",thePlayer) 
    end 
end 
) 
  

--Client side

LINE NUMBER ON/OFF | EXPAND/CONTRACT | SELECT ALL 
function getElementSpeed(element,unit) 
    if (unit == nil) then unit = 0 end 
    if (isElement(element)) then 
        local x,y,z = getElementVelocity(element) 
        if (unit=="mph" or unit==1 or unit =='1') then 
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
        else 
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.61 * 100 
        end 
    else 
        outputDebugString("Not an element. Can't get speed") 
        return false 
    end 
end 
  
addEvent( 'enableFishermanMission', true ) 
addEventHandler( 'enableFishermanMission', getRootElement( ), 
    function( ) 
        if ( source == localPlayer ) then 
            addEventHandler( 'onClientRender', getRootElement( ), FishermanGUIText ) 
            Timer = setTimer( checkfishesbleh, 5000, 0 ) 
        end 
    end 
) 
  
function checkfishesbleh( ) 
    local vehicle = getPedOccupiedVehicle( localPlayer ) 
    if ( vehicle ) then 
    local aSpeed = getElementSpeed( vehicle, 'kph' ) 
    local curfish = getElementData( vehicle, 'fishes' ) or 0 
        if ( curfish > 499 ) then 
            setElementData( vehicle, 'fishes', 500 ) 
        else 
            if ( aSpeed >= 20 ) then 
                setElementData( vehicle, 'fishes', ( curfish + math.random( 4 ) ) ) 
            end 
        end 
    end 
end 
  
addEvent ("disableFishermanMission",true) 
addEventHandler ("disableFishermanMission",getRootElement(), 
function() 
    if (source == getLocalPlayer()) then 
        removeEventHandler ("onClientRender",getRootElement(),FishermanGUIText) 
        killTimer(checkfishesbleh) 
    end 
end 
) 

[abu5lf]

Client Side

Timer = {} 
  
function getElementSpeed(element,unit) 
    if (unit == nil) then unit = 0 end 
    if (isElement(element)) then 
        local x,y,z = getElementVelocity(element) 
        if (unit=="mph" or unit==1 or unit =='1') then 
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
        else 
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.61 * 100 
        end 
    else 
        outputDebugString("Not an element. Can't get speed") 
        return false 
    end 
end 
  
addEvent( 'enableFishermanMission', true ) 
addEventHandler( 'enableFishermanMission', getRootElement( ), 
    function( ) 
        if ( source == localPlayer ) then 
            addEventHandler( 'onClientRender', getRootElement( ), FishermanGUIText ) 
            Timer[localPlayer] = setTimer( checkfishesbleh, 5000, 0 ) 
        end 
    end 
) 
  
function checkfishesbleh( ) 
    local vehicle = getPedOccupiedVehicle( localPlayer ) 
    if ( vehicle ) then 
    local aSpeed = getElementSpeed( vehicle, 'kph' ) 
    local curfish = getElementData( vehicle, 'fishes' ) or 0 
        if ( curfish > 499 ) then 
            setElementData( vehicle, 'fishes', 500 ) 
        else 
            if ( aSpeed >= 20 ) then 
                setElementData( vehicle, 'fishes', ( curfish + math.random( 4 ) ) ) 
            end 
        end 
    end 
end 
  
addEvent( 'disableFishermanMission', true ) 
addEventHandler( 'disableFishermanMission', getRootElement( ), 
    function() 
        if ( source == localPlayer ) then 
            removeEventHandler( 'onClientRender', getRootElement( ),FishermanGUIText ) 
            killTimer( Timer[localPlayer] ) 
        end 
    end 
) 

Server Side

local index, theBoat; 
  
for index,theBoat in ipairs ( getElementsByType ( "vehicle" ) ) do 
    if ( getElementModel( theBoat )  == 453 ) then 
        setElementData( theBoat, 'fishboat', true ) 
        setElementData( theBoat, 'fishes', 0 ) 
    end 
end 
  
finish = createMarker( 971.8, -2103.6, 2.2,"cylinder", 2, 0, 0, 255, 155) 
FishingMinigameBlip = createBlipAttachedTo ( finish, 9, 2, 0, 0, 255, 255, 0, 250, getRootElement() ) 
  
addEventHandler( 'onMarkerHit', finish, 
    function (thePlayer) 
        if ( getElementType( thePlayer) == 'player' ) then 
            local fishes = getElementData( getPedOccupiedVehicle( thePlayer ), 'fishes' ) or 0 
            outputChatBox( 'You have sold '..fishes..' fishes and earned $'..fishes * 3,thePlayer) 
            givePlayerMoney( thePlayer,fishes* 3 ) 
            setElementData( thePlayer, 'fishes', 0, false ) 
        end 
    end 
) 
  
addEventHandler( 'onVehicleEnter', getRootElement( ), 
    function( thePlayer ) 
        if getElementData( source,'fishboat' ) then 
            triggerClientEvent( thePlayer, 'enableFishermanMission', thePlayer ) 
        end 
    end 
) 
  
addEventHandler ( "onVehicleExit", getRootElement(), 
    function( thePlayer ) 
        if getElementData( source, 'fishboat' ) then 
            triggerClientEvent( thePlayer, 'disableFishermanMission',thePlayer ) 
        end 
    end 
) 

[K4stic]

same no fishes

[abu5lf]

local index, theBoat; 
  
for index, theBoat in ipairs ( getElementsByType 'vehicle' ) do 
    if ( getElementModel( theBoat )  == 453 ) then 
        setElementData( theBoat, 'fishboat', true ) 
        setElementData( theBoat, 'fishes', 0 ) 
    end 
end 
  
finish = createMarker( 971.8, -2103.6, 2.2,"cylinder", 2, 0, 0, 255, 155) 
FishingMinigameBlip = createBlipAttachedTo ( finish, 9, 2, 0, 0, 255, 255, 0, 250, getRootElement() ) 
  
addEventHandler( 'onMarkerHit', finish, 
    function( hit ) 
        if ( getElementType( hit ) == 'player' ) then 
            local fishes = getElementData( hit , 'FishPlayer' ) or 0 
            outputChatBox( 'You have sold '..fishes..' fishes and earned $'.. fishes * 3, thePlayer ) 
            givePlayerMoney( hit, fishes * 3 ) 
            setElementData( hit, 'FishPlayer', 0 ) 
        end 
    end 
) 
  
addEventHandler( 'onVehicleEnter', getRootElement( ), 
    function( thePlayer ) 
        if getElementData( source, 'fishboat' ) then 
            triggerClientEvent( thePlayer, 'enableFishermanMission', thePlayer ) 
        end 
    end 
) 
  
addEventHandler ( 'onVehicleExit', getRootElement( ), 
    function( thePlayer ) 
        if getElementData( source, 'fishboat' ) then 
            triggerClientEvent( thePlayer, 'disableFishermanMission', thePlayer ) 
            setElementData( thePlayer, 'FishPlayer', getElementData( source , 'fishes' ) or 0 ) 
            setElementData( source, 'fishes', 0 ) 
        end 
    end 
) 

Edited January 6, 2013 by Guest

[K4stic]

thx work but i need to player hit it and sell the fish

[abu5lf]

thx work but i need to player hit it and sell the fish

Copy code again.

[Anderl]

Btw, there's no need to declare variables of the for loop.

[K4stic]

BIG thx 3ɑsн8 ɑʟsнɾq

[abu5lf]

You're welcome.

[K4stic]

work's good but how make it to take first the job and the spawn boat and go to fishing

because now is :need have spawned the boat and then take the job to get fish

[K4stic]

and another help pls it's says error => attempt to perform arithmetic on a boolean value

    setElementData ( source, "cans", (getElementData(source, "cans") + cans), false ) 

[Vision]

setElementData ( source, "cans", tonumber(getElementData(source, "cans") or 0) + cans, false ) 

[K4stic]

Thx Castro

[Vision]

You're welcome.