saving players score,

[liamknight24]

ok so i want to save my players kills and i cant figure it out ::

function onPlayerQuit ( )
local playeraccount = getPlayerAccount ( source )
if ( playeraccount ) then
local kills = getElementData ( source, "the kills" )
setAccountData ( playeraccount, "kills", kills )
end
end
 
function onPlayerLogin ( )
local playeraccount = getPlayerAccount ( source )
if ( playeraccount ) then
local kills = getAccountData ( playeraccount, "kills" )
if ( kills ) then
            setPlayerScore( source, "the kills", kills )
end
end
end
 
addEventHandler ( "onPlayerQuit", getRootElement ( ), onPlayerQuit )
addEventHandler ( "onPlayerLogin", getRootElement ( ), onPlayerLogin )

any help will be appreciated.

[liamknight24]

ok so i want to save my players kills and i cant figure it out ::

function onPlayerQuit ( )
local playeraccount = getPlayerAccount ( source )
if ( playeraccount ) then
local kills = getElementData ( source, "the kills" )
setAccountData ( playeraccount, "kills", kills )
end
end
 
function onPlayerLogin ( )
local playeraccount = getPlayerAccount ( source )
if ( playeraccount ) then
local kills = getAccountData ( playeraccount, "kills" )
if ( kills ) then
            setPlayerScore( source, "the kills", kills )
end
end
end
 
addEventHandler ( "onPlayerQuit", getRootElement ( ), onPlayerQuit )
addEventHandler ( "onPlayerLogin", getRootElement ( ), onPlayerLogin )

any help will be appreciated.

[Gamesnert]

A few questions:

setPlayerScore( source, "the kills", kills )

Does this function actually exist?

function onPlayerLogin ( )
local playeraccount = getPlayerAccount ( source )
if ( playeraccount ) then

Why are you using getPlayerAccount if onPlayerLogin actually has a parameter containing the currently used account? It could just be done as:

function onPlayerLogin ( blah, playeraccount )

Perhaps that might also be the solution to your problem.

local kills = getElementData ( source, "the kills" )

I'm not sure how get/setElementData responds to spaces in the name, but as a last resort you could try removing it.

[Gamesnert]

A few questions:

setPlayerScore( source, "the kills", kills )

Does this function actually exist?

function onPlayerLogin ( )      local playeraccount = getPlayerAccount ( source )      if ( playeraccount ) then

Why are you using getPlayerAccount if onPlayerLogin actually has a parameter containing the currently used account? It could just be done as:

function onPlayerLogin ( blah, playeraccount )

Perhaps that might also be the solution to your problem.

local kills = getElementData ( source, "the kills" )

I'm not sure how get/setElementData responds to spaces in the name, but as a last resort you could try removing it.

[50p]

....

local kills = getElementData ( source, "the kills" )

I'm not sure how get/setElementData responds to spaces in the name, but as a last resort you could try removing it.

It's a string. It doesn't matter if it has spaces, same for custom event names (addEvent).

@liamknight24,

getPlaterAccount in every player event with source passed as argument will always return player account. I would advice to check if account isGuestAccount.

[50p]

....

local kills = getElementData ( source, "the kills" )

I'm not sure how get/setElementData responds to spaces in the name, but as a last resort you could try removing it.

It's a string. It doesn't matter if it has spaces, same for custom event names (addEvent).

@liamknight24,

getPlaterAccount in every player event with source passed as argument will always return player account. I would advice to check if account isGuestAccount.

[subenji99]

50p didn't make that very clear so I'll just elaborate here - getPlayerAccount will never fail to return an account as long as a valid player element is passed to it. However, anyone that is not logged in has a guest account.

Data is never permanently saved to a guest account, (erased when the player quits) and cannot be retrieved on a later connect. That's why 50p is recommending you check isGuestAccount.

[subenji99]

50p didn't make that very clear so I'll just elaborate here - getPlayerAccount will never fail to return an account as long as a valid player element is passed to it. However, anyone that is not logged in has a guest account.

Data is never permanently saved to a guest account, (erased when the player quits) and cannot be retrieved on a later connect. That's why 50p is recommending you check isGuestAccount.

[liamknight24]

function onPlayerQuit ( ) 
local kills = getElementData ( source, "the kills" )
setAccountData ( playeraccount, "kills", kills )
end
 
function onPlayerLogin ( ) -- if this is not a real function what can i put there instead?
local kills = getAccountData ( playeraccount, "kills" )
if ( kills ) then
           setPlayerScoreboardForced( player, "the kills", kills )
end
end
 
addEventHandler ( "onPlayerQuit", getRootElement ( ), onPlayerQuit )
addEventHandler ( "onPlayerLogin", getRootElement ( ), onPlayerLogin )

i tested it and it still dosent work the script i showed before saved the kills but did not put them onto the scoreboard, and also 50p players have to login if they want to play on the server so i dont think i need to check if its a guest account, but thanks for the info guys.

[liamknight24]

function onPlayerQuit ( ) 
local kills = getElementData ( source, "the kills" )
setAccountData ( playeraccount, "kills", kills )
end
 
function onPlayerLogin ( ) -- if this is not a real function what can i put there instead?
local kills = getAccountData ( playeraccount, "kills" )
if ( kills ) then
           setPlayerScoreboardForced( player, "the kills", kills )
end
end
 
addEventHandler ( "onPlayerQuit", getRootElement ( ), onPlayerQuit )
addEventHandler ( "onPlayerLogin", getRootElement ( ), onPlayerLogin )

i tested it and it still dosent work the script i showed before saved the kills but did not put them onto the scoreboard, and also 50p players have to login if they want to play on the server so i dont think i need to check if its a guest account, but thanks for the info guys.

[robhol]

Well, obviously they don't... you haven't defined playeraccount anywhere. For onPlayerQuit, use getPlayerAccount(), for onPlayerLogin, it is passed as an argument to the event handler. Check the wiki page.

setPlayerScoreboardForced doesn't do anything of that sort... use setElementData.

[robhol]

Well, obviously they don't... you haven't defined playeraccount anywhere. For onPlayerQuit, use getPlayerAccount(), for onPlayerLogin, it is passed as an argument to the event handler. Check the wiki page.

setPlayerScoreboardForced doesn't do anything of that sort... use setElementData.