Marker table problem

[swedishboy]

Hello. I cant see the markers and im getting this warning in debugscript

Bad argument @ 'addEventHandler' [expected element at argument 2, got nil]

	local spots = {
{2488.32886, -1670.63599, 12.33595},
{2490.92886, -1670.63599, 12.33595},
{2495.92886, -1670.63599, 12.33595},
}
    
function getHp (player)
    for k,v in ipairs (spots) do
    marker1 = createMarker(v[1],v[2],v[3], "cylinder", 1.2, 22, 22, 22)
    end    
    local money = getPlayerMoney(player)
    local hpp = getElementHealth(player)
    if money >= 1000 and hpp < 100 then
       setElementHealth(player, 100)
       takePlayerMoney(player, 1000)
    elseif money >= 1000 and hpp >= 100 then
       outputChatBox("Your HP is already full", player, 222, 44, 22)
    elseif money < 1000 then
       outputChatBox("You don't have enough money", player, 222, 44, 22)
    end
end
addEventHandler("onMarkerHit", marker1, getHp)
	

[Gordon_G]

It can not works because "marker1" is created inside the fonction who is handled. You can not handle a marker who do not exist.

So, you'll need to create "marker1" before handling it.

[NeXuS™]

local spots = {
	{2488.32886, -1670.63599, 12.33595},
	{2490.92886, -1670.63599, 12.33595},
	{2495.92886, -1670.63599, 12.33595}
}

for k,v in ipairs (spots) do
	marker1 = createMarker(v[1],v[2],v[3], "cylinder", 1.2, 22, 22, 22) -- Creating the markers when the resource is started.
	addEventHandler("onMarkerHit", marker1, getHp) -- Handling markerhits for every marker which is created.
end

function getHp (player)
	local money = getPlayerMoney(player)
	local hpp = getElementHealth(player)
	if money >= 1000 and hpp < 100 then
		setElementHealth(player, 100)
		takePlayerMoney(player, 1000)
	elseif money >= 1000 and hpp >= 100 then
		outputChatBox("Your HP is already full", player, 222, 44, 22)
	elseif money < 1000 then
		outputChatBox("You don't have enough money", player, 222, 44, 22)
	end
end

I think this one should work.

[swedishboy]

I can see the markers with this code but still not working.. getting this warning Bad argument @ 'addEventHandler' [expected element at argument 3, got nil]

	local spots = {
{2488.32886, -1670.63599, 12.33595},
{2490.92886, -1670.63599, 12.33595},
{2495.92886, -1670.63599, 12.33595}
}
	for k,v in ipairs (spots) do
    marker1 = createMarker(v[1],v[2],v[3], "cylinder", 1.2, 22, 22, 22)
    addEventHandler("onMarkerHit", marker1, getHp)
end    
function getHp (player)
    local money = getPlayerMoney(player)
    local hpp = getElementHealth(player)
    if money >= 1000 and hpp < 100 then
       setElementHealth(player, 100)
       takePlayerMoney(player, 1000)
    elseif money >= 1000 and hpp >= 100 then
       outputChatBox("Your HP is already full", player, 222, 44, 22)
    elseif money < 1000 then
       outputChatBox("You don't have enough money", player, 222, 44, 22)
    end
end
	

[Gordon_G]

Move the fonction gethp to the top

[swedishboy]

Like this?

	local spots = {
{2488.32886, -1670.63599, 12.33595},
{2490.92886, -1670.63599, 12.33595},
{2495.92886, -1670.63599, 12.33595}
}
	function getHp (player)
    for k,v in ipairs (spots) do
    marker1 = createMarker(v[1],v[2],v[3], "cylinder", 1.2, 22, 22, 22)
    addEventHandler("onMarkerHit", marker1, getHp)
    end    
	    local money = getPlayerMoney(player)
    local hpp = getElementHealth(player)
    if money >= 1000 and hpp < 100 then
       setElementHealth(player, 100)
       takePlayerMoney(player, 1000)
    elseif money >= 1000 and hpp >= 100 then
       outputChatBox("Your HP is already full", player, 222, 44, 22)
    elseif money < 1000 then
       outputChatBox("You don't have enough money", player, 222, 44, 22)
    end
end
	

[Oussema]

markers = {}

local spots = {
{2488.32886, -1670.63599, 12.33595},
{2490.92886, -1670.63599, 12.33595},
{2495.92886, -1670.63599, 12.33595}
}



for k,v in ipairs (spots) do
    markers[k] = createMarker(v[1],v[2],v[3], "cylinder", 1.2, 22, 22, 22)
    addEventHandler("onMarkerHit", markers[k], function()
    local money = getPlayerMoney(hitElement)
    local hpp = getElementHealth(hitElement)
    if money >= 1000 and hpp < 100 then
       setElementHealth(hitElement, 100)
       takePlayerMoney(hitElement, 1000)
    elseif money >= 1000 and hpp >= 100 then
       outputChatBox("Your HP is already full", hitElement, 222, 44, 22)
    elseif money < 1000 then
       outputChatBox("You don't have enough money", hitElement, 222, 44, 22)
    end
    end)
end	

	

This gonna work

Edited April 15, 2017 by Oussema

[DNL291]

That will not work.

[Oussema]

ye all right  

16 minutes ago, DNL291 said:

That will not work.

Edited  now it's gonna work , simple fail ahaha

[DNL291]

'hitElement' paramenter is missing in the function.

[Oussema]

markers = {}

local spots = {
{2488.32886, -1670.63599, 12.33595},
{2490.92886, -1670.63599, 12.33595},
{2495.92886, -1670.63599, 12.33595}
}



for k,v in ipairs (spots) do
    markers[k] = createMarker(v[1],v[2],v[3], "cylinder", 1.2, 22, 22, 22)
    addEventHandler("onMarkerHit", markers[k], function(hitElement, mtd)
    local money = getPlayerMoney(hitElement)
    local hpp = getElementHealth(hitElement)
    if money >= 1000 and hpp < 100 then
       setElementHealth(hitElement, 100)
       takePlayerMoney(hitElement, 1000)
    elseif money >= 1000 and hpp >= 100 then
       outputChatBox("Your HP is already full", hitElement, 222, 44, 22)
    elseif money < 1000 then
       outputChatBox("You don't have enough money", hitElement, 222, 44, 22)
    end
    end

i don't see them :v anyway thx  now it's gonna work i'm sure

[swedishboy]

Thanks but that wont work

[swedishboy]

I made this and it works but only on 1 marker not on all markers in the table..

	local spots = {
{2488.32886, -1670.63599, 12.33595},
{2490.92886, -1670.63599, 12.33595},
{2495.92886, -1670.63599, 12.33595}
}
	for  k,v in ipairs (spots) do
    marker1 = createMarker(v[1], v[2], v[3], "cylinder", 1.2, 22, 22, 22)
end
    
function getHp (player)
    local money = getPlayerMoney(player)
    local hpp = getElementHealth(player)
    if money >= 1000 and hpp < 100 then
       setElementHealth(player, 100)
       takePlayerMoney(player, 1000)
    elseif money >= 1000 and hpp >= 100 then
       outputChatBox("Your HP is already full", player, 222, 44, 22)
    elseif money < 1000 then
       outputChatBox("You don't have enough money", player, 222, 44, 22)
    end
end
addEventHandler("onMarkerHit", marker1, getHp)
	

[Mr.Loki]

local markers={}
local spots = {
    {2488.32886, -1670.63599, 12.33595},
    {2490.92886, -1670.63599, 12.33595},
    {2495.92886, -1670.63599, 12.33595}
}

for  k,v in ipairs (spots) do
    local m = createMarker(v[1], v[2], v[3], "cylinder", 1.2, 22, 22, 22)
    markers[m] = true
end
    
function getHp (player)
    local money = getPlayerMoney(player)
    local hpp = getElementHealth(player)
    if markers[source] and money >= 1000 then
        if hpp < 100 then
            setElementHealth(player, 100)
            takePlayerMoney(player, 1000)
        elseif money >= 1000 and hpp >= 100 then
            outputChatBox("Your HP is already full", player, 222, 44, 22)
        end
    else
       outputChatBox("You don't have enough money", player, 222, 44, 22)
    end
end
addEventHandler("onMarkerHit", resourceRoot, getHp)

 

[swedishboy]

@mr.Loki Thanks alot!

[Mr.Loki]

No prob @swedishboy