Check data

[Klesh]

Im trying to get the data when the player is login, doesnt show it!

    addEvent( 'onPlayerRaceWasted',true ) 
    addEvent( "stats", true ) 
      
    exports[ 'scoreboard' ]:addScoreboardColumn( 'Wins' ) 
    --exports[ 'scoreboard' ]:addScoreboardColumn( 'Deaths' ) 
    --exports[ 'scoreboard' ]:addScoreboardColumn( 'ratio' ) 
      
    local restriction = { } 
      
    function restrictionEnd( playerName ) 
        restriction[ playerName ] = nil 
    end 
      
      
    function publicstatsinfo( ) 
        if isElement( source ) then 
            local account = getPlayerAccount( source ) 
            if account then 
                if isGuestAccount( account ) then return end 
                local askdname = getPlayerName( source ) 
                local wins = getAccountData( account, "Wins" ) or 0 
                local loses = getAccountData( account, "Deaths" ) or 0 
                if loses and wins then 
                    --outputChatBox("#FFA824*" .. askdname .. " won " .. tostring( wins ) .. " times and he lost " ..tostring( loses ).. " times, his ratio is " .. tostring( ratio ) .. "%", root, 255, 12, 15, true) 
                end 
            end 
        else 
            outputChatBox( "Error source is not player" ) 
        end 
    end 
      
    
      
    function DestructionWin( vehicle ) 
        local alivePlayers = getAlivePlayers( ) 
        if #alivePlayers == 1 then 
            if isElement( alivePlayers[1] ) then 
                local account = getPlayerAccount( alivePlayers[1] ) 
                if isGuestAccount( account ) then return end 
                local count = tonumber( getAccountData( account,"Wins" ) or 0 ) + 1 
                setAccountData( account,"Wins",count ) 
                setElementData( alivePlayers[1],'Wins', count ) 
                --outputChatBox ( "#FFA824The player " .. getPlayerName( alivePlayers[1] ) .. " won!", root, 255, 255, 255, true ) 
            end 
        else 
            local account = getPlayerAccount( source ) 
            if isGuestAccount( account ) then return end 
            local loses = tonumber( getAccountData( account,"Deaths" ) or 0 ) + 1 
            setAccountData( account,"Deaths", loses ) 
            setElementData( source,'Deaths', loses ) 
        end 
    end 
     
        function onPlayerLogin ( _, acc ) 
        if acc then 
            local acc = getPlayerAccount ( source ) 
            local wins = getAccountData( account, "Wins" ) 
            if wins then 
               setAccountData(acc, wins) 
            end 
        end 
    end 
    addEventHandler ( "onPlayerLogin",root, onPlayerLogin ) 
      
      
    addEventHandler( "stats", root, publicstatsinfo ) 
    addEventHandler( "onPlayerRaceWasted", root,DestructionWin ) 
     
     

[Castillo]

Instead of:

setAccountData(acc, wins) 

It should be:

setElementData ( source, "Wins", wins ) 

[Klesh]

Changed, still the same error, the data doesn't set when player login!

[HunT]

  
  local count = tonumber( getAccountData( account,"Wins" ) or 0 ) + 1 -- ????? 
                                      setAccountData( account,"Wins",count ) 
  

Why Not

  
local count = tonumber ( getAccountData ( account , "Wins" ) ) or 0 
     setAccountData ( account, "Wins",  tonumber(count) + 1) 
  

[Anderl]

  
  local count = tonumber( getAccountData( account,"Wins" ) or 0 ) + 1 -- ????? 
                                      setAccountData( account,"Wins",count ) 
  

Why Not

  
local count = tonumber ( getAccountData ( account , "Wins" ) ) or 0 
     setAccountData ( account, "Wins",  tonumber(count) + 1) 
  

It makes no sense changing it because it's exactly the same.

[HunT]

  
  local count = tonumber( getAccountData( account,"Wins" ) or 0 ) + 1 -- ????? 
                                      setAccountData( account,"Wins",count ) 
  

Why Not

  
local count = tonumber ( getAccountData ( account , "Wins" ) ) or 0 
     setAccountData ( account, "Wins",  tonumber(count) + 1) 
  

It makes no sense changing it because it's exactly the same.

But why u reply everytimes negative in my post ? What is u problem?

This is correct :

  
local count = tonumber ( getAccountData ( account , "Wins" ) ) or 0 
     setAccountData ( account, "Wins",  tonumber(count) + 1) 
  

[Klesh]

In fact, this resolves something about this? when the player joins show the wins he/she have, its empty.

[Castillo]

Changed, still the same error, the data doesn't set when player login!

Try adding a debug output to see what 'wins' return when you login.

@Hunterix: Is both the same thing, it won't make any difference.

[Anderl]

  
  local count = tonumber( getAccountData( account,"Wins" ) or 0 ) + 1 -- ????? 
                                      setAccountData( account,"Wins",count ) 
  

Why Not

  
local count = tonumber ( getAccountData ( account , "Wins" ) ) or 0 
     setAccountData ( account, "Wins",  tonumber(count) + 1) 
  

It makes no sense changing it because it's exactly the same.

But why u reply everytimes negative in my post ? What is u problem?

This is correct :

  
local count = tonumber ( getAccountData ( account , "Wins" ) ) or 0 
     setAccountData ( account, "Wins",  tonumber(count) + 1) 
  

It's not negative, I just said the truth. And as I said already before, it is correct just like the code he had before.

[Klesh]

Nothing, empty!

[HunT]

  
exports.scoreboard:addScoreboardColumn('Wins') 
function winScore () 
local sourceAccount = getPlayerAccount ( source ) 
local count = tonumber ( getAccountData ( sourceAccount , "Wins" ) ) or 0 
if count == false then 
setElementData ( source, "Wins", "0" ) 
else 
setElementData ( source, "Wins", count ) 
end 
end 
addEventHandler ( "onPlayerSpawn", getRootElement(), winScore ) 
addEventHandler ( "onPlayerLogin", getRootElement(), winScore ) 
  

Tested with other Data

[Castillo]

function onPlayerLogin ( _, acc ) 
    if ( acc ) then 
        local wins = tonumber ( getAccountData ( account, "Wins" ) ) or 0 
        setElementData ( source, "Wins", wins ) 
    end 
end 
addEventHandler ( "onPlayerLogin",root, onPlayerLogin ) 

That's easier.

[Klesh]

It works but if the player has 20 wins and he/she login the data is 0 no 20, at least if he wins when the map finish!

[Castillo]

Which means the script is not really saving anything.

[Klesh]

How i can save this data ?

    addEvent( 'onPlayerRaceWasted',true ) 
    addEvent( "stats", true ) 
      
    exports[ 'scoreboard' ]:addScoreboardColumn( 'Wins' ) 
    --exports[ 'scoreboard' ]:addScoreboardColumn( 'Deaths' ) 
    --exports[ 'scoreboard' ]:addScoreboardColumn( 'ratio' ) 
      
    local restriction = { } 
      
    function restrictionEnd( playerName ) 
        restriction[ playerName ] = nil 
    end 
      
      
    function publicstatsinfo( ) 
        if isElement( source ) then 
            local account = getPlayerAccount( source ) 
            if account then 
                if isGuestAccount( account ) then return end 
                local askdname = getPlayerName( source ) 
                local wins = getAccountData( account, "Wins" ) or 0 
                local loses = getAccountData( account, "Deaths" ) or 0 
                if loses and wins then 
                    --outputChatBox("#FFA824*" .. askdname .. " won " .. tostring( wins ) .. " times and he lost " ..tostring( loses ).. " times, his ratio is " .. tostring( ratio ) .. "%", root, 255, 12, 15, true) 
                end 
            end 
        else 
            outputChatBox( "Error source is not player" ) 
        end 
    end 
      
    
      
    function DestructionWin( vehicle ) 
        local alivePlayers = getAlivePlayers( ) 
        if #alivePlayers == 1 then 
            if isElement( alivePlayers[1] ) then 
                local account = getPlayerAccount( alivePlayers[1] ) 
                if isGuestAccount( account ) then return end 
                local count = tonumber( getAccountData( account,"Wins" ) ) or 0  
                setAccountData( account,"Wins",count ) 
                setElementData( alivePlayers[1],'Wins', count ) 
                --outputChatBox ( "#FFA824The player " .. getPlayerName( alivePlayers[1] ) .. " won!", root, 255, 255, 255, true ) 
            end 
        else 
            local account = getPlayerAccount( source ) 
            if isGuestAccount( account ) then return end 
            local loses = tonumber( getAccountData( account,"Deaths" ) or 0 ) + 1 
            setAccountData( account,"Deaths", loses ) 
            setElementData( source,'Deaths', loses ) 
        end 
    end 
     
    function onPlayerLogin ( _, acc ) 
        if ( acc ) then 
            local wins = tonumber ( getAccountData ( account, "Wins" ) ) or 0 
            setElementData ( source, "Wins", wins ) 
        end 
    end 
    addEventHandler ( "onPlayerLogin",root, onPlayerLogin ) 
      
      
    addEventHandler( "stats", root, publicstatsinfo ) 
    addEventHandler( "onPlayerRaceWasted", root,DestructionWin ) 
     
     

[Castillo]

function DestructionWin ( vehicle ) 
    local alivePlayers = getAlivePlayers ( ) 
    if ( #alivePlayers == 1 ) then 
        if isElement ( alivePlayers[1] ) then 
            local account = getPlayerAccount ( alivePlayers[1] ) 
            if isGuestAccount ( account ) then 
                return 
            end 
  
            local count = ( tonumber ( getAccountData ( account, "Wins" ) ) or 0 ) + 1 
            setAccountData ( account, "Wins", count ) 
            setElementData ( alivePlayers[1], 'Wins', count ) 
            --outputChatBox ( "#FFA824The player " .. getPlayerName( alivePlayers[1] ) .. " won!", root, 255, 255, 255, true ) 
        end 
    else 
        local account = getPlayerAccount ( source ) 
        if isGuestAccount ( account ) then 
            return 
        end 
  
        local loses = ( tonumber ( getAccountData( account,"Deaths" ) or 0 ) ) + 1 
        setAccountData ( account, "Deaths", loses ) 
        setElementData ( source, 'Deaths', loses ) 
    end 
end 

[Klesh]

Now doesn't work when someone wins, and is the same, onPlayerlogin doesn't show the data, i try to fix it but nothing!

[Castillo]

Is not even updating the 'Wins' element data?

[Klesh]

I fix it by my own, thanks anyways to everyone!

[Castillo]

function DestructionWin ( vehicle ) 
    local alivePlayers = getAlivePlayers ( ) 
    if ( #alivePlayers == 1 ) then 
        outputChatBox ( "Passed check #1" ) 
        if isElement ( alivePlayers[1] ) then 
            outputChatBox ( "Passed check #2" ) 
            local account = getPlayerAccount ( alivePlayers[1] ) 
            if isGuestAccount ( account ) then 
                return 
            end 
            outputChatBox ( "Passed check #3" ) 
  
            local count = ( tonumber ( getAccountData ( account, "Wins" ) ) or 0 ) + 1 
            setAccountData ( account, "Wins", count ) 
            setElementData ( alivePlayers[1], 'Wins', count ) 
            --outputChatBox ( "#FFA824The player " .. getPlayerName( alivePlayers[1] ) .. " won!", root, 255, 255, 255, true ) 
        end 
    else 
        local account = getPlayerAccount ( source ) 
        if isGuestAccount ( account ) then 
            return 
        end 
  
        local loses = ( tonumber ( getAccountData( account,"Deaths" ) or 0 ) ) + 1 
        setAccountData ( account, "Deaths", loses ) 
        setElementData ( source, 'Deaths', loses ) 
    end 
end 

Post here what does it output to chat.

[Klesh]

Fixed Solid

[Castillo]

Mind telling us what was it?