[HELP] bad argument @ 'getPlayerTeam'

[Pikachu]

i need someone to help me with my script, i run it i see at the console (bad argument @ 'getPlayerTeam')

function:

function onTeamJoin(thePlayer) 
    if not getPlayerTeam(thePlayer) then return end 
    if getTeamName(getPlayerTeam(thePlayer)) == "Mailmen" then 
    local x, y, z = getNewMailLocation(thePlayer, 1) 
    setElementData(thePlayer, "mailData", 1) 
    end 
end 
addEventHandler("onElementDataChange",rootElement,onTeamJoin) 

[robhol]

Use source, and you need to check if the element is a player before acting on it.

[Tete omar]

try this:

rootElement = getRootElement() 
  
function onTeamJoin() 
    if not getPlayerTeam(source) then return end 
    if getTeamName(getPlayerTeam(source)) == "Mailmen" then 
    local x, y, z = getNewMailLocation(source, 1) 
    setElementData(source, "mailData", 1) 
    end 
    end 
addEventHandler("onElementDataChange",rootElement,onTeamJoin) 

[Flaker]

In function https://wiki.multitheftauto.com/wiki/OnElementDataChange, first argument is the name of the element data entry that changed

Player can be source of this event.

The source of this event is the element whose elementdata changed.

Also, u should check that the element is a player before acting on it.

So, this code is more correct:

function onTeamJoin(dataName) 
    if (source and getElementType(source) == "player" and getPlayerTeam(source) ) then 
        if ( getTeamName(getPlayerTeam(source)) == "Mailmen" ) then 
            local x, y, z = getNewMailLocation(source, 1) 
            setElementData(source, "mailData", 1) 
        end 
    end 
end 
addEventHandler("onElementDataChange",root,onTeamJoin) 

Also u can check data name. For example:

  
function func(dataName) 
    if ( dataName == "mailData" ) then --Data Name Check 
    -- CODE HERE 
    end 
end 
addEventHandler("onElementDataChange",root,func) 

Edited August 15, 2012 by Guest

[Tete omar]

rootElement is not defined anyway .. correct your code