Player Respawn

[itHyperoX]

Hello guys. I made a script, very simple onPlayerWasted respawn the player.

When i'm disconnecting while im dead, and trying to logIn, the server just froze ("NETWORK TROUBLE").

And i get these debug messages:

 

the screen is just black, and after a few seconds the player respawning.

Whats the problem? Here is the code:

 

addEventHandler("onPlayerJoin",root,function()
    spawn(source)
end)
--< Spawn >--
function spawn(source)
    x, y, z = 2028.4606933594, 1342.2176513672, 10.8203125
    repeat until spawnPlayer(source,x+1,y+1,z, 0,303)
    setCameraTarget(source, player)
    fadeCamera(source, true) 
    setElementRotation(source, 0, 0, -90)
end
addEventHandler("onPlayerWasted",root,function()
    exports["rc_core"]:takeMoney(source,5000)
    skin = getElementModel(source) or 0
    setTimer(respawn, 5000, 1, source)
    setTimer(setElementModel,5000,1,source,skin)
end)

--< Respawn >--
function respawn(source)
    x, y, z = 2270.298828125, 1399.2269287109, 42.8203125
    repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )
    setCameraTarget(source, player)
    fadeCamera(source, true) 
    setElementRotation(source, 0, 0, -90)
end

 

Edited July 18, 2017 by TheMOG

[itHyperoX]

up

[f8upd8]

setTimer(respawn, 5000, 1, source)

setTimer(setElementModel,5000,1,source,skin)

 

Syntax is incorrect. If function needs any arguments, use timer like this:
 

setTimer(function ()

setElementModel(source, skin)

end, 5000, 1)

 

And just for your sake, wipe out of the world's face this:

 

repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )

[itHyperoX]

4 hours ago, f8upd8 said:

setTimer(respawn, 5000, 1, source)

setTimer(setElementModel,5000,1,source,skin)

 

Syntax is incorrect. If function needs any arguments, use timer like this:
 

setTimer(function ()

setElementModel(source, skin)

end, 5000, 1)

 

And just for your sake, wipe out of the world's face this:

 

repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )

 

Thank you.

Why should i wipe that?

 

Also,

bad argument @ "setElementModel" [expected element at argument 1 ,got nil]

 

Also2//

Deleted the repeat until, but  if i reconnect when im dead i'm getting a 100 hp.

Edited July 19, 2017 by TheMOG

[Gordon_G]

So, if I understand correctly. When you are dead and you disconnect you want to be dead when you reconnect ?

Use accountData or SQL.

[itHyperoX]

2 hours ago, Gordon_G said:

So, if I understand correctly. When you are dead and you disconnect you want to be dead when you reconnect ?

Use accountData or SQL.

I'm saving player datas. The problem is, when player reconnect while dead. I want to make that, when player login, and health 0, spawning the player instant

Now i added this to the saving system

 

    if isPedDead(source) or (getElementHealth(source)) < 1 then 
        setElementHealth(source,100)
        setAccountData(account,"acc.health",100)    
    end    

 

Also, i added "if isElement(source) then ....

so, how can i make that possible, if player disconnecting while dead, the system  cancelEvent the setTimer

addEventHandler("onPlayerWasted",root,function()
    if isElement(source) then
        exports["rc_core"]:takeMoney(source,5000)
        skin = getElementModel(source) or 0
        setTimer(respawn,3000, 1, source)
        setTimer(setElementModel,3000,1,source,skin)
    end
end)

--< Respawn >--
function respawn(source)
    if isElement(source) then
        x, y, z = 2270.298828125, 1399.2269287109, 42.8203125
        repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )
        setCameraTarget(source, player)
        fadeCamera(source, true) 
        setElementRotation(source, 0, 0, -90)
    end
end

 

Edited July 19, 2017 by TheMOG

[f8upd8]

4 hours ago, TheMOG said:

I'm saving player datas. The problem is, when player reconnect while dead. I want to make that, when player login, and health 0, spawning the player instant

Now i added this to the saving system

 

    if isPedDead(source) or (getElementHealth(source)) < 1 then 
        setElementHealth(source,100)
        setAccountData(account,"acc.health",100)    
    end    

 

Also, i added "if isElement(source) then ....

so, how can i make that possible, if player disconnecting while dead, the system  cancelEvent the setTimer

addEventHandler("onPlayerWasted",root,function()
    if isElement(source) then
        exports["rc_core"]:takeMoney(source,5000)
        skin = getElementModel(source) or 0
        setTimer(respawn,3000, 1, source)
        setTimer(setElementModel,3000,1,source,skin)
    end
end)

--< Respawn >--
function respawn(source)
    if isElement(source) then
        x, y, z = 2270.298828125, 1399.2269287109, 42.8203125
        repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )
        setCameraTarget(source, player)
        fadeCamera(source, true) 
        setElementRotation(source, 0, 0, -90)
    end
end

You did not gave to function setElementModel and respawn any arguments.

Lua function usage syntax looks like: function (arg1, arg2).

And your syntax: function, arg1, arg2

Bad Syntax. You should learn lua a bit before start scripting.

 repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )

 

Why to wipe? When fucntion inits, player will respawn "while true", e.g. infinite times. This caused network trouble, i guess. My machine is slow and if i did like you, i will need to restart my computer.

 

Sorry for my bad english.

Edited July 19, 2017 by f8upd8

[itHyperoX]

But i just making a script, not opening server, is that hard to help ? Please dont comment here

[f8upd8]

6 minutes ago, TheMOG said:

But i just making a script, not opening server, is that hard to help ? Please dont comment here

Oh. Take it easy. It is hard to me to be gentlemen because of my basic english. I just wanted to give advice. I did not mean to be rude. I'm sorry.

[pa3ck]

2 hours ago, f8upd8 said:

You did not gave to function setElementModel and respawn any arguments.

Lua function usage syntax looks like: function (arg1, arg2).

And your syntax: function, arg1, arg2

Bad Syntax. You should learn lua a bit before start scripting.

 repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )

 

Why to wipe? When fucntion inits, player will respawn "while true", e.g. infinite times. This caused network trouble, i guess. My machine is slow and if i did like you, i will need to restart my computer.

 

Sorry for my bad english.

What are you on about like..? How would that be infinite loop, spawnPlayer returns true, so as soon as it spawns the player, it will be terminated, but actually it's not needed anyway, since there's nothing between repeat and until - which is basically the body of the repeat function...

You should look up how stuff work before educating others, setTimer(setElementModel, 5000, 1, source, 200) is perfectly valid, since after the '1' (number of times the timer should run) you can pass arguments into the setElementModel function...

Edited July 19, 2017 by pa3ck

[f8upd8]

19 minutes ago, pa3ck said:

What are you on about like..? How would that be infinite loop, spawnPlayer returns true, so as soon as it spawns the player, it will be terminated, but actually it's not needed anyway, since there's nothing between repeat and until - which is basically the body of the repeat function...

You should look up how stuff work before educating others, setTimer(setElementModel, 5000, 1, source, 200) is perfectly valid, since after the '1' (number of times the timer should rund) you can pass arguments into the setElementModel function...

Wow. I did not known that. Sorry for my dumbness.

But

repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )

Is only thing that can cause server freeze due to error. Because of invalid argument passed. I said while true and that is wrong. I should say "until false"

But even if i dumb, i had same problem and will be helpful. Try to create local variable that contains source element, i thing source don't getting through timer function.

addEventHandler("onPlayerWasted",root,function()
    local thePlayer = source
    if isElement(thePlayer) then
        exports["rc_core"]:takeMoney(thePlayer,5000)
        skin = getElementModel(thePlayer) or 0
        setTimer(respawn,3000, 1, thePlayer)
        setTimer(setElementModel,3000,1,thePlayer,skin)
    end
end)

I hope that will be just one helpful post i left here.

Edited July 19, 2017 by f8upd8

[Master_MTA]

On ١٨‏/٧‏/٢٠١٧ at 20:38, TheMOG said:

Hello guys. I made a script, very simple onPlayerWasted respawn the player.

When i'm disconnecting while im dead, and trying to logIn, the server just froze ("NETWORK TROUBLE").

And i get these debug messages:

 

the screen is just black, and after a few seconds the player respawning.

Whats the problem? Here is the code:

 

addEventHandler("onPlayerJoin",root,function()
    spawn(source)
end)
--< Spawn >--
function spawn(source)
    x, y, z = 2028.4606933594, 1342.2176513672, 10.8203125
    repeat until spawnPlayer(source,x+1,y+1,z, 0,303)
    setCameraTarget(source, player)
    fadeCamera(source, true) 
    setElementRotation(source, 0, 0, -90)
end
addEventHandler("onPlayerWasted",root,function()
    exports["rc_core"]:takeMoney(source,5000)
    skin = getElementModel(source) or 0
    setTimer(respawn, 5000, 1, source)
    setTimer(setElementModel,5000,1,source,skin)
end)

--< Respawn >--
function respawn(source)
    x, y, z = 2270.298828125, 1399.2269287109, 42.8203125
    repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )
    setCameraTarget(source, player)
    fadeCamera(source, true) 
    setElementRotation(source, 0, 0, -90)
end

 

if i understood you correctly try this code

executeSQLQuery("CREATE TABLE IF NOT EXISTS testtable (isdead TEXT, serial TEXT)")

addEventHaandler('onPlayerQuit',root,function()
  local serial=getPlayerSerial(source)
    if isPedDead(source) and serial then
  executeSQLQuery('INSERT INTO testtable VALUES(?,?)','true',serial)    
  end
  end)
addEventHandler('onPlayerLogin',root,function()
  local sql=executeSQLQuery('SELECT * FROM testtable WHERE serial=?',getPlayerSerial(source))
    if #sql~=0 then
      killPed(source)
      fadeCamera(source,false)
    setTimer(function(plr)
        local serial=getPlayerSerial(plr)     
          executeSQLQuery("DELETE FROM testtable WHERE serial=?", serial)
          fadeCamera(plr,true)
        end,1000*2,1,source)
    end
  end)

i didn't test it

[pa3ck]

59 minutes ago, f8upd8 said:

Wow. I did not known that. Sorry for my dumbness.

But

repeat until spawnPlayer(source,x+1, y+1,z, 0, math.random(1,1) )

Is only thing that can cause server freeze due to error. Because of invalid argument passed. I said while true and that is wrong. I should say "until false"

But even if i dumb, i had same problem and will be helpful. Try to create local variable that contains source element, i thing source don't getting through timer function.

addEventHandler("onPlayerWasted",root,function()
    local thePlayer = source
    if isElement(thePlayer) then
        exports["rc_core"]:takeMoney(thePlayer,5000)
        skin = getElementModel(thePlayer) or 0
        setTimer(respawn,3000, 1, thePlayer)
        setTimer(setElementModel,3000,1,thePlayer,skin)
    end
end)

I hope that will be just one helpful post i left here.

No, it's not like a while true do loop, it is a repeat until true - as soon as it's true, it will end.

I think the player element was the problem as well, when the setTimer fired, the source was no longer available, so declaring thePlayer as source should work. 

[itHyperoX]

The problem is, when i die, and reconnecting, on the server console i see so many debug errors (Pictures first comment). 

I'm 100% sure, the problem is the script not checking the player is on the server because of the timer!. So,  i think i have to use cancelEvent if the player disconnect.

So, how can i make that? I never saw these errors before.

Edited July 19, 2017 by TheMOG

[pa3ck]

Save the timers in a table and set the key to be the player element. When onPlayerQuit fires, check if there's a timer in the table using the source as the key, if so, use killTimer()

[itHyperoX]

Can you please help me with that? As i said, i'm new and keep learning, but no leaking.. 

[itHyperoX]

...

[pa3ck]

local timers = {}

addEventHandler("onPlayerWasted",root,function()
    local thePlayer = source
    if isElement(thePlayer) then
      exports["rc_core"]:takeMoney(thePlayer,5000)
      skin = getElementModel(thePlayer) or 0
      if isTimer(timers[thePlayer]) then killTimer(timers[thePlayer]) end
      timers[thePlayer] = setTimer(function() 
        respawn(thePlayer)
        setElementModel(thePlayer, skin)
      end, 3000, 1)
    end
end)
  
addEventHandler("onPlayerQuit", root, function()
      if isTimer(timers[source]) then killTimer(timers[source]) end
end)

 

[itHyperoX]

Again you dude.. Thank you.

[pa3ck]

You're welcome.