[Help] I need some help on a script I have been working on

[mint3d]

Ok so I need help on this script I have been working on so basically it sets all vehicles in the faction but I only want it to set all elegys in the faction can someone help me out please?

function setHandling() 
  for key,veh in ipairs(getElementsByType("vehicle")) do 
   if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 20) 
    setVehicleHandling(veh, "maxVelocity", 165) 
    setVehicleHandling(veh, "steeringLock", 45) 
   end 
   if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 22) 
    setVehicleHandling(veh, "maxVelocity", 200) 
    setVehicleHandling(veh, "steeringLock", 50) 
   end 
   if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 15) 
    setVehicleHandling(veh, "maxVelocity", 180) 
    setVehicleHandling(veh, "brakeDeceleration", 1000) 
    setVehicleHandling(veh, "tractionMultiplier", 0.9) 
    end 
    if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 22) 
    setVehicleHandling(veh, "maxVelocity", 200) 
    setVehicleHandling(veh, "steeringLock", 50) 
    setVehicleHandling(veh, "brakeDeceleration", 1000) 
    end 
  end 
end 
addEventHandler("onResourceStart", getRootElement(), setHandling) 

Edited May 22, 2014 by Guest

[justn]

function setHandling() 
  for key,veh in ipairs(getElementsByType("vehicle")) do 
   if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 20) 
    setVehicleHandling(veh, "maxVelocity", 165) 
    setVehicleHandling(veh, "steeringLock", 45) 
   end 
   if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 22) 
    setVehicleHandling(veh, "maxVelocity", 200) 
    setVehicleHandling(veh, "steeringLock", 50) 
   end 
   if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 15) 
    setVehicleHandling(veh, "maxVelocity", 180) 
    setVehicleHandling(veh, "brakeDeceleration", 1000) 
    setVehicleHandling(veh, "tractionMultiplier", 0)--. 
    end 
    if (getElementData(veh, "faction") == 72) then 
    setVehicleHandling(veh, "engineAcceleration", 22) 
    setVehicleHandling(veh, "maxVelocity", 200) 
    setVehicleHandling(veh, "steeringLock", 50) 
    setVehicleHandling(veh, "brakeDeceleration", 1000) 
    end 
  end 
end 
addEventHandler("onResourceStart", getRootElement(), setHandling) 

[mint3d]

Ye line 17 is like that because its 0. 8 ) its a smiley... so I just made it 0.9) to make life easier lol

[mint3d]

*BUMP*

[tosfera]

Double post, you can't bump your post which its latest reply was 9 minutes ago. Way to go man, anyway.

If you only want to edit the Elegy, just add a check in there;

if ( getElementModel ( veh ) == ) then 

like so;

function setHandling() 
    for key,veh in ipairs ( getElementsByType ( "vehicle" ) ) do 
        if ( getElementModel ( veh ) == 562 ) then 
            if ( getElementData ( veh, "faction" ) == 72 ) then 
                setVehicleHandling ( veh, "engineAcceleration", 20 ); 
                setVehicleHandling ( veh, "maxVelocity", 165 ); 
                setVehicleHandling ( veh, "steeringLock", 45 ); 
            end 
             
            if ( getElementData ( veh, "faction" ) == 72) then 
                setVehicleHandling ( veh, "engineAcceleration", 22 ); 
                setVehicleHandling ( veh, "maxVelocity", 200 ); 
                setVehicleHandling ( veh, "steeringLock", 50 ); 
            end 
             
            if ( getElementData ( veh, "faction" ) == 72) then 
                setVehicleHandling ( veh, "engineAcceleration", 15 ); 
                setVehicleHandling ( veh, "maxVelocity", 180 ); 
                setVehicleHandling ( veh, "brakeDeceleration", 1000 ); 
                setVehicleHandling ( veh, "tractionMultiplier", 0.9 ); 
            end 
             
            if ( getElementData ( veh, "faction" ) == 72) then 
                setVehicleHandling ( veh, "engineAcceleration", 22 ); 
                setVehicleHandling ( veh, "maxVelocity", 200 ); 
                setVehicleHandling ( veh, "steeringLock", 50 ); 
                setVehicleHandling ( veh, "brakeDeceleration", 1000 ); 
            end 
        end 
    end 
end 
addEventHandler ( "onResourceStart", getRootElement(), setHandling ) 

And why do you have the if-statement 4 times btw? I'm talking about this one;

if ( getElementData ( veh, "faction" ) == 72 ) then 

[mint3d]

lol I am being a noob where should I add that? sorry for me being a noob lol new to this

[tosfera]

I edited your code, just replace it with your old code.

[mint3d]

I don't know why I have it stated that many times I don't know how to make it less coding lol

[tosfera]

function setHandling() 
    for key,veh in ipairs ( getElementsByType ( "vehicle" ) ) do 
        if ( getElementModel ( veh ) == 562 ) then 
            if ( getElementData ( veh, "faction" ) == 72 ) then 
                setVehicleHandling ( veh, "tractionMultiplier", 0.9 ); 
                setVehicleHandling ( veh, "engineAcceleration", 22 ); 
                setVehicleHandling ( veh, "maxVelocity", 200 ); 
                setVehicleHandling ( veh, "steeringLock", 50 ); 
                setVehicleHandling ( veh, "brakeDeceleration", 1000 ); 
            end 
        end 
    end 
end 
addEventHandler ( "onResourceStart", getRootElement(), setHandling ) 

[mint3d]

Your first script worked for only elegys and ye I have a lot of different values at each of them so I don't know