Reward for killing

[zzx]

I made a script, if anyone killed another player with his hunter, he will get 200$

but only with hunter.

local reward = 200 
  
function kill ( ammo, killer, killerweapon, bodypart ) 
    local vehicle = getPedOccupiedVehicle ( killer ) 
    if isPedInVehicle ( killer ) and getElementModel ( vehicle ) == 425 then 
    givePlayerMoney ( source, reward ) 
            outputChatBox ("#ff8800[REWARD] #ffffffYou have killed "..getPlayerName..( source )" ..and rewarded $".. tostring ( reward ), root, 0, 255, 0, true ) 
        end 
    end 
addEventHandler ( "onPlayerWasted", getRootElement(), kill ) 

help please

[-.Paradox.-]

local reward = 200 
  
function kill ( ammo, killer, killerweapon, bodypart ) 
    local vehicle = getPedOccupiedVehicle ( killer ) 
    local veh = getVehicleID(vehicle) 
    if isPedInVehicle ( killer ) and veh == 425 then 
    givePlayerMoney ( killer, reward ) 
            outputChatBox ("#ff8800[REWARD] #ffffffYou have killed "..getPlayerName..( source )" ..and rewarded $".. tostring ( reward ), killer, 0, 255, 0, true ) 
        end 
    end 
addEventHandler ( "onPlayerWasted", getRootElement(), kill ) 

[zzx]

thanks =D

[-.Paradox.-]

You're welcome.

[Tete omar]

local reward = 200 
  
function kill ( ammo, killer, killerweapon, bodypart ) 
    local vehicle = getPedOccupiedVehicle ( killer ) 
    local veh = getVehicleID(vehicle) 
    if isPedInVehicle ( killer ) and veh == 425 then 
    givePlayerMoney ( killer, reward ) 
            outputChatBox ("#ff8800[REWARD] #ffffffYou have killed "..getPlayerName..( source )" ..and rewarded $".. tostring ( reward ), killer, 0, 255, 0, true ) 
        end 
    end 
addEventHandler ( "onPlayerWasted", getRootElement(), kill ) 

This won't work, first, getVehicleID is a deprecated function, second, you're defining the vehicle without checking whether the killer is a player.

This should work i guess:

local reward = 200 
  
function kill ( ammo, killer, killerweapon, bodypart ) 
    if ( getElementType ( killer ) == "vehicle" ) then 
        if ( getElementModel ( killer ) == 425 ) then 
            local controller = getVehicleController ( killer ) 
            givePlayerMoney ( controller, reward ) 
            outputChatBox ("#ff8800[REWARD] #ffffffYou have killed " .. getPlayerName ( source ) .. " and rewarded $" .. reward, controller, 255, 255, 255, true ) 
        end 
    end 
end 
addEventHandler ( "onPlayerWasted", getRootElement(), kill ) 

[-.Paradox.-]

local reward = 200 
  
function kill ( ammo, killer, killerweapon, bodypart ) 
    local vehicle = getPedOccupiedVehicle ( killer ) 
    local veh = getVehicleID(vehicle) 
    if isPedInVehicle ( killer ) and veh == 425 then 
    givePlayerMoney ( killer, reward ) 
            outputChatBox ("#ff8800[REWARD] #ffffffYou have killed "..getPlayerName..( source )" ..and rewarded $".. tostring ( reward ), killer, 0, 255, 0, true ) 
        end 
    end 
addEventHandler ( "onPlayerWasted", getRootElement(), kill ) 

This won't work, first, getVehicleID is a deprecated function, second, you're defining the vehicle without checking whether the killer is a player.

This should work i guess:

local reward = 200 
  
function kill ( ammo, killer, killerweapon, bodypart ) 
    if ( getElementType ( killer ) == "vehicle" ) then 
        if ( getElementModel ( killer ) == 425 ) then 
            local controller = getVehicleController ( killer ) 
            givePlayerMoney ( controller, reward ) 
            outputChatBox ("#ff8800[REWARD] #ffffffYou have killed " .. getPlayerName ( source ) .. " and rewarded $" .. reward, controller, 255, 255, 255, true ) 
        end 
    end 
end 
addEventHandler ( "onPlayerWasted", getRootElement(), kill ) 

My bad, this one should work yeah.

[IIYAMA]

Note: Check if there is a controller, it can be none.

[Tete omar]

Yeah, i thought of that, but the hunter can never be without a controller when it kills someone, that's impossible

[IIYAMA]

Yeah, i thought of that, but the hunter can never be without a controller when it kills someone, that's impossible

You sure about that?

local vehicles = getElementsByType("vehicle") 
for i=1, #vehicles do 
    local vehicle = vehicles[i] 
    setElementVelocity ( vehicle,0,0, 30 ) 
end 
  
setTimer(function() 
    local vehicles = getElementsByType("vehicle") 
    for i=1, #vehicles do 
        local vehicle = vehicles[i] 
        setElementVelocity ( vehicle,0,0, -30 ) 
    end      
end,1000,1) 

If you have low hp and you get rammed by a falling hunter?

[Tete omar]

If you have low hp and you get rammed by a falling hunter?

Which is probably too rare to be happened

[zzx]

I already kept tete's code, anyhow thanks to everyone.

[-.Paradox.-]

My code had many mistakes, I'm glad that Tete fixed it.

You're welcome anyway.