Little help with script

[isa_Khamdan]

Hello ,

I want to make a script that destroy cars if they stop in a collshape ( safe area ) for 5 seconds so if someone stopped his car and didn't move in 5 seconds the car will be destroyed.

So I am going to use If isElementWithinCollsShape to check if the vehicle inside the safe area or not and then I will use getElementSpeed to see if the element is moving or not and if it's speed is 0 then it will destroy it

So it's all good now but there is one thing that I didn't figure out how to do it

How can I make it count the time so if player stopped his vehicle for 5 seconds then it will destroy it?

[Castillo]

setTimer 
destroyElement 

[isa_Khamdan]

setTimer 
destroyElement 

Why it doesn't work?

local Line1 = createColRectangle ( -1287.9871826172, -217.75384521484, 500, 500) 
  
function SafeZoneA(thePlayer) 
    if getElementType ( thePlayer ) == "vehicle" then 
        if (isElementWithinColShape(thePlayer, Line1)) then 
    if getElementVelocity ( thePlayer == 0) then 
    setTimer ( destroyElement , 10000, 1, thePlayer )  
  
        end 
    end 
 end 
end  
addEventHandler ( "onColShapeHit", getRootElement(), SafeZoneA ) 

[Castillo]

if getElementVelocity ( thePlayer == 0) then 

That's wrong, change it to:

if ( getElementVelocity ( thePlayer ) == 0 ) then 

[isa_Khamdan]

if getElementVelocity ( thePlayer == 0) then 

That's wrong, change it to:

if ( getElementVelocity ( thePlayer ) == 0 ) then 

it doesn't work?

[Castillo]

getElementVelocity returns 3 values: velocity X, velocitY and velocityZ.

https://wiki.multitheftauto.com/wiki/GetElementSpeed

You could try with that, remember to copy the function source code, as is not a native function.

[isa_Khamdan]

It doesn't work

local Line1 = createColRectangle ( -1318.4671630859, -189.9077911377, 1000, 1000) 
  
  
  
function SafeZoneA(thePlayer) 
    if getElementType ( thePlayer ) == "vehicle" then 
        if (isElementWithinColShape(thePlayer, Line1)) then  
    if ( getElementVelocity ( thePlayer ) == 0 ) then 
    setTimer ( destroyElement , 1000, 1, thePlayer )  
  
        end 
    end 
 end 
end  
addEventHandler ( "onColShapeHit", getRootElement(), SafeZoneA ) 
  
  
function getElementSpeed(element,unit) 
    if (unit == nil) then unit = 0 end 
    if (isElement(element)) then 
        local x,y,z = getElementVelocity(element) 
        if (unit=="mph" or unit==1 or unit =='1') then 
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
        else 
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.8 * 100 
        end 
    else 
        outputDebugString("Not an element. Can't get speed") 
        return false 
    end 
end 

[Castillo]

And where are you using the getElementSpeed function? you're still using getElementVelocity...

[isa_Khamdan]

And where are you using the getElementSpeed function? you're still using getElementVelocity...

Still the same

local Line1 = createColRectangle ( -1318.4671630859, -189.9077911377, 1000, 1000) 
  
  
  
function SafeZoneA(Vehicle) 
    if getElementType ( Vehicle ) == "vehicle" then 
        if (isElementWithinColShape(Vehicle, Line1)) then    
    local Speed = getElementSpeed(Vehicle,"kmh") 
    if Speed == 0 then 
    setTimer ( destroyElement , 1000, 1, Vehicle )  
  
        end 
    end 
 end 
end  
addEventHandler ( "onColShapeHit", getRootElement(), SafeZoneA ) 
  
  
function getElementSpeed(element,unit) 
    if (unit == nil) then unit = 0 end 
    if (isElement(element)) then 
        local x,y,z = getElementVelocity(element) 
        if (unit=="mph" or unit==1 or unit =='1') then 
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
        else 
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.8 * 100 
        end 
    else 
        outputDebugString("Not an element. Can't get speed") 
        return false 
    end 
end 

[Blaawee]

local Line1 = createColRectangle ( -1318.4671630859, -189.9077911377, 1000, 1000) 
  
  
  
function SafeZoneA( element ) 
    if source == Line1 then 
        if getElementType ( element ) == "vehicle" then 
            if ( isElementWithinColShape( element, source ) ) then    
                if getElementSpeed( element ) == 0 then 
                    setTimer ( destroyElement , 1000, 1, element ) 
                end 
            end 
        end 
    end 
end 
addEventHandler ( "onColShapeHit", resourceRoot, SafeZoneA ) 
  
function getElementSpeed(element,unit) 
    if (unit == nil) then unit = 0 end 
    if (isElement(element)) then 
        local x,y,z = getElementVelocity(element) 
        if (unit=="mph" or unit==1 or unit =='1') then 
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
        else 
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.8 * 100 
        end 
    else 
        outputDebugString("Not an element. Can't get speed") 
        return false 
    end 
end 

[isa_Khamdan]

local Line1 = createColRectangle ( -1318.4671630859, -189.9077911377, 1000, 1000) 
  
  
  
function SafeZoneA( element ) 
    if source == Line1 then 
        if getElementType ( element ) == "vehicle" then 
            if ( isElementWithinColShape( element, source ) ) then    
                if getElementSpeed( element ) == 0 then 
                    setTimer ( destroyElement , 1000, 1, element ) 
                end 
            end 
        end 
    end 
end 
addEventHandler ( "onColShapeHit", resourceRoot, SafeZoneA ) 
  
function getElementSpeed(element,unit) 
    if (unit == nil) then unit = 0 end 
    if (isElement(element)) then 
        local x,y,z = getElementVelocity(element) 
        if (unit=="mph" or unit==1 or unit =='1') then 
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
        else 
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.8 * 100 
        end 
    else 
        outputDebugString("Not an element. Can't get speed") 
        return false 
    end 
end 

It doesn't destroy the vehicle

and there are no errors in debug

Edit: it only destroy the car if there was no one driving it

[Castillo]

Have you checked what getElementSpeed is returning?

[isa_Khamdan]

Have you checked what getElementSpeed is returning?

No , How can I fix it?

[Castillo]

Before this line:

if getElementSpeed( element ) == 0 then 

Add:

outputChatBox ( tostring ( getElementSpeed ( element ) ) ) 

[isa_Khamdan]

Before this line:

if getElementSpeed( element ) == 0 then 

Add:

outputChatBox ( tostring ( getElementSpeed ( element ) ) ) 

It return the speed "142.87299415513"

[Castillo]

Which means that the vehicle will not be destroyed, because the speed has to be 0.

[isa_Khamdan]

Which means that the vehicle will not be destroyed, because the speed has to be 0.

I used a timer so if the vehicle stopped for 5 seconds it will get destroyed or what I did is wrong?

[Castillo]

No, because the timer is AFTER you check the speed, so the timer will never be created if the speed isn't 0.

[isa_Khamdan]

No, because the timer is AFTER you check the speed, so the timer will never be created if the speed isn't 0.

Hmm I forgot that

So how can I fix it?

Edit: will this work?

Getting the speed first then check if the speed is 0 or not and if not then return?

[Castillo]

You can set the timer to execute a function which will check the vehicle speed, if it's 0, then destroy the vehicle.

[isa_Khamdan]

You can set the timer to execute a function which will check the vehicle speed, if it's 0, then destroy the vehicle.

How can I make a timer like this?

I made the Function

function Destroy( element ) 
  
    local Speed = getElementSpeed( element )  
   if getElementType ( element ) == "vehicle" then 
   if Speed == 0 then    
       destroyElement( element ) 
  
  end 
 end 
end 

[Castillo]

Yes, then you set the 10 seconds timer to execute "Destroy" function, and you have to pass "element" as an argument.

[isa_Khamdan]

Yes, then you set the 10 seconds timer to execute "Destroy" function, and you have to pass "element" as an argument.

This should work?

local Line1 = createColRectangle ( -1318.4671630859, -189.9077911377, 1000, 1000) 
  
  
  
 function Destroy( element ) 
  
    local Speed = getElementSpeed( element )  
   if getElementType ( element ) == "vehicle" then 
   if Speed == 0 then    
       destroyElement( element ) 
  
  end 
 end 
end 
addEvent ( "Destroy", true ) 
  
addEventHandler ( "onColShapeHit", resourceRoot, Destroy ) 
  
  
  
function SafeZoneA( element ) 
  
    if source == Line1 then 
  
        if getElementType ( element ) == "vehicle" then 
  
            if ( isElementWithinColShape( element, source ) ) then    
                 
                    setTimer ( triggerEvent , 5000, 1, Destroy ) 
  
                end 
  
            end 
  
        end 
  
    end 
  
end 
  
addEventHandler ( "onColShapeHit", resourceRoot, SafeZoneA ) 
  
  
  
function getElementSpeed(element,unit) 
  
    if (unit == nil) then unit = 0 end 
  
    if (isElement(element)) then 
  
        local x,y,z = getElementVelocity(element) 
  
        if (unit=="mph" or unit==1 or unit =='1') then 
  
            return (x^2 + y^2 + z^2) ^ 0.5 * 100 
  
        else 
  
            return (x^2 + y^2 + z^2) ^ 0.5 * 1.8 * 100 
  
        end 
  
    else 
  
        outputDebugString("Not an element. Can't get speed") 
  
        return false 
  
    end 
  
end 

[Castillo]

No, that doesn't make any sense.

[isa_Khamdan]

No, that doesn't make any sense.

I searched the Wiki but I didn't find anything about execute Function