toptime deleting error

[bartje01]

Hey guys. I 'm trying to show my deleting toptimes script showing up in a dxdrawtext instead of a simple output.

I have this:

  
addCommandHandler( "deletetime", 
    function( player, cmd, place ) 
          
          
        if deleteTimeOnline == false then return outputChatBox("#33ccffDeleting toptimes disabled by default",player,255,255,255,true) end 
        if not _TESTING and not isPlayerInACLGroup(player, g_Settings.admingroup) then 
            return 
        end 
        if g_SToptimesManager and g_SToptimesManager.mapTimes then 
            local row = g_SToptimesManager.mapTimes:deletetime(place) 
            if row then 
                g_SToptimesManager:updateTopText() 
                local mapName = tostring(g_SToptimesManager.mapTimes.mapName) 
                local placeText = place and " #" .. tostring(place) or "" 
                dxDrawText ( mapName, 44, screenHeight - 43, screenWidth, screenHeight, tocolor ( 255, 255, 255, 255 ), 1, "deleting" ) 
                outputServerLog( "INFO: Top time"..placeText.." from '" ..tostring(row.playerName).. "' (" ..tostring(row.timeText).. " in " ..mapName.. ") deleted by " .. getAdminNameForLog(player) ) 
            end 
        end 
    end 
  
) 
  

And this errors:

  
[2013-02-19 13:55:49] ERROR: unzipped\race_toptimes\toptimes_server.lua:398: attempt to perform arithmetic on global 'screenHeight' (a nil value) 
[2013-02-19 13:55:59] ERROR: unzipped\race_toptimes\toptimes_server.lua:398: attempt to perform arithmetic on global 'screenHeight' (a nil value) 
  

Could anyone please help me?

[Sparrow]

you forgot:

local screenHeight, screenWidth = guiGetScreenSize()  

[Castillo]

That's obviously a server side script, and dxDrawText is a client side only function.

[bartje01]

Okay, I've got this now:

server side:

  
addCommandHandler( "deletetime", 
    function( player, cmd, place ) 
          
         
        if deleteTimeOnline == false then return outputChatBox("#33ccffDeleting toptimes disabled by default",player,255,255,255,true) end 
        if not _TESTING and not isPlayerInACLGroup(player, g_Settings.admingroup) then 
            return 
        end 
        if g_SToptimesManager and g_SToptimesManager.mapTimes then 
            local row = g_SToptimesManager.mapTimes:deletetime(place) 
            if row then 
                g_SToptimesManager:updateTopText() 
                local mapName = tostring(g_SToptimesManager.mapTimes.mapName) 
                local placeText = place and " #" .. tostring(place) or "" 
                triggerClientEvent ( "onDeleting", getRootElement(), "Hello World!" ) 
                outputServerLog( "INFO: Top time"..placeText.." from '" ..tostring(row.playerName).. "' (" ..tostring(row.timeText).. " in " ..mapName.. ") deleted by " .. getAdminNameForLog(player) ) 
            end 
        end 
    end 
  
) 
  

client side:

  
function deleteTimeHandler (mapName,placeText) 
local screenHeight, screenWidth = guiGetScreenSize() 
local mapName = tostring(g_SToptimesManager.mapTimes.mapName) 
local placeText = place and " #" .. tostring(place) or "" 
dxDrawText ( mapName, 44, screenHeight - 43, screenWidth, screenHeight, tocolor ( 255, 255, 255, 255 ), 1, "deleting" ) 
  
end 
  
addEvent( "onDeleting", true ) 
addEventHandler( "onDeleting", getRootElement(), deleteTimeHandler ) 
  

How much did I fuck up here ?

[Castillo]

All dx drawing functions require onClientRender event in order to work.

[bartje01]

Hmm. I don't really know what to do with that. Could you show me how to?

[bartje01]

Hmm?

[Castillo]

-- client side:

local mapName, placeText 
local screenHeight, screenWidth = guiGetScreenSize ( ) 
  
function deleteTimeHandler ( map, place ) 
    removeEventHandler ( "onClientRender", root, renderText ) 
    mapName, placeText = map, place 
    addEventHandler ( "onClientRender", root, renderText ) 
end 
addEvent ( "onDeleting", true ) 
addEventHandler ( "onDeleting", getRootElement(), deleteTimeHandler ) 
  
function renderText ( ) 
    dxDrawText ( mapName, 44, screenHeight - 43, screenWidth, screenHeight, tocolor ( 255, 255, 255, 255 ), 1, "default" ) 
end 

-- server side:

addCommandHandler( "deletetime", 
    function( player, cmd, place )  
        if deleteTimeOnline == false then return outputChatBox("#33ccffDeleting toptimes disabled by default",player,255,255,255,true) end 
        if not _TESTING and not isPlayerInACLGroup(player, g_Settings.admingroup) then 
            return 
        end 
  
        if g_SToptimesManager and g_SToptimesManager.mapTimes then 
            local row = g_SToptimesManager.mapTimes:deletetime(place) 
            if row then 
                g_SToptimesManager:updateTopText() 
                local mapName = tostring(g_SToptimesManager.mapTimes.mapName) 
                local placeText = place and " #" .. tostring(place) or "" 
                triggerClientEvent ( "onDeleting", getRootElement(), mapName, placeText ) 
                outputServerLog( "INFO: Top time"..placeText.." from '" ..tostring(row.playerName).. "' (" ..tostring(row.timeText).. " in " ..mapName.. ") deleted by " .. getAdminNameForLog(player) ) 
            end 
        end 
    end 
) 

Try it.

[bartje01]

It still has no effect :l No errors and also no draw in my screen

[Castillo]

Should work, ur sure that there's no errors?

[bartje01]

Very sure

[Castillo]

The position of the text must be wrong, because I just tested it and the function is working, it's drawing it, but not where you can see it.

[bartje01]

I put this below the draw line in the client sided file:

outputConsole ( "Public console message" )

Even that doesnt show up in the console

[Castillo]

I did this and it started spamming the chat box:

local mapName, placeText 
local screenHeight, screenWidth = guiGetScreenSize ( ) 
  
function deleteTimeHandler ( map, place ) 
    removeEventHandler ( "onClientRender", root, renderText ) 
    mapName, placeText = map, place 
    addEventHandler ( "onClientRender", root, renderText ) 
end 
addEvent ( "onDeleting", true ) 
addEventHandler ( "onDeleting", getRootElement(), deleteTimeHandler ) 
  
function renderText ( ) 
outputChatBox ( "RENDERING" ) 
    dxDrawText ( mapName, 44, screenHeight - 43, screenWidth, screenHeight, tocolor ( 255, 255, 255, 255 ), 1, "default" ) 
end