Teams

[Drakath]

I have some kind of bug or error, here's the deal: I made a script so every player should join a team "All" but when player log ins, he doesn't join the team. Did I make mistake in script or is it something else?

Script:

function createAllTeamOnStart () 
    AllTeam = createTeam ( "All", 0, 255, 0 ) 
end 
addEventHandler("onResourceStart", resourceRoot, createAllTeamOnStart) 
  
function setAllTeam() 
if isObjectInACLGroup("user."..getAccountName(getPlayerAccount(source)), aclGetGroup("Everyone")) then 
   setPlayerTeam(source, AllTeam) 
   end 
end 
addEventHandler("onPlayerLogin",getRootElement(),setAllTeam) 
addEventHandler("onPlayerJoin",getRootElement(),setAllTeam) 
addEventHandler("onPlayerSpawn",getRootElement(),setAllTeam) 
addEventHandler("onClientLoginLoaded",getRootElement(),setAllTeam) 
addEventHandler("onResourceStart",getRootElement(),setAllTeam) 
addEventHandler("onRequestLogin",getRootElement(),setAllTeam) 
addEventHandler("onRequestAutologin",getRootElement(),setAllTeam) 

[Castillo]

The only problem I see is that you are using onResourceStart to set the team, but 'source' of that event is not a player.

function createAllTeamOnStart ( ) 
    AllTeam = createTeam ( "All", 0, 255, 0 ) 
    for index, player in ipairs ( getElementsByType ( "player" ) ) do 
        if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( player ) ), aclGetGroup ( "Everyone" ) ) then 
            setPlayerTeam ( player, AllTeam ) 
        end 
    end 
end 
addEventHandler ( "onResourceStart", resourceRoot, createAllTeamOnStart ) 
  
function setAllTeam ( ) 
    if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( source ) ), aclGetGroup ( "Everyone" ) ) then 
        setPlayerTeam ( source, AllTeam ) 
    end 
end 
addEventHandler ( "onPlayerLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerJoin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerSpawn", getRootElement(), setAllTeam ) 
addEventHandler ( "onClientLoginLoaded", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestAutologin", getRootElement(), setAllTeam ) 

[Drakath]

Still same problem... When player connect he is in team, but when he log in he is removed from team.

[Xeno]

I had this problem a long time ago, you have to get the team by name and then set team.

function createAllTeamOnStart ( ) 
    AllTeam = createTeam ( "All", 0, 255, 0 ) 
    for index, player in ipairs ( getElementsByType ( "player" ) ) do 
        if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( player ) ), aclGetGroup ( "Everyone" ) ) then 
            team = getTeamFromName("All") 
            setPlayerTeam ( player, team ) 
        end 
    end 
end 
addEventHandler ( "onResourceStart", resourceRoot, createAllTeamOnStart ) 
  
function setAllTeam ( ) 
    if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( source ) ), aclGetGroup ( "Everyone" ) ) then 
        team = getTeamFromName("All") 
        setPlayerTeam ( source, team ) 
    end 
end 
addEventHandler ( "onPlayerLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerJoin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerSpawn", getRootElement(), setAllTeam ) 
addEventHandler ( "onClientLoginLoaded", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestAutologin", getRootElement(), setAllTeam ) 

[Drakath]

Still same problem...

[Xeno]

You have not created a new team for the Logged in people.

[Drakath]

I tried to reconnect and when I did I wasn't in team.

[Xeno]

Try and set a timer on the setPlayerTeam.

[Drakath]

I got some error: ERROR: setteam\dteam.lua:26: stack overflow

function createAllTeamOnStart ( ) 
    AllTeam = createTeam ( "All", 0, 255, 0 ) 
    for index, player in ipairs ( getElementsByType ( "player" ) ) do 
        if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( player ) ), aclGetGroup ( "Everyone" ) ) then 
            team = getTeamFromName("All") 
            setPlayerTeam ( player, team ) 
        end 
    end 
end 
addEventHandler ( "onResourceStart", resourceRoot, createAllTeamOnStart ) 
  
function setAllTeam ( ) 
    if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( source ) ), aclGetGroup ( "Everyone" ) ) then 
        team = getTeamFromName("All") 
        setPlayerTeam ( source, team ) 
    end 
end 
addEventHandler ( "onPlayerLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerJoin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerSpawn", getRootElement(), setAllTeam ) 
addEventHandler ( "onClientLoginLoaded", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestAutologin", getRootElement(), setAllTeam ) 
  
function setPlayerTeam() 
        setPlayerTeam ( player, team ) 
    setTimer ( function() 
        setPlayerTeam ( player, team ) 
    end, 5000, 1 ) 
end 
  
setPlayerTeam() 

[Guest Guest4401]

function createAllTeamOnStart ( ) 
    AllTeam = createTeam ( "All", 0, 255, 0 ) 
    for index, player in ipairs ( getElementsByType ( "player" ) ) do 
        if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( player ) ), aclGetGroup ( "Everyone" ) ) then 
            team = getTeamFromName("All") 
            setPlayerTeam ( player, team ) 
        end 
    end 
end 
addEventHandler ( "onResourceStart", resourceRoot, createAllTeamOnStart ) 
  
function setAllTeam ( ) 
    if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( source ) ), aclGetGroup ( "Everyone" ) ) then 
        team = getTeamFromName("All") 
        setPlayerTeam ( source, team ) 
    end 
end 
addEventHandler ( "onPlayerLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerJoin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerSpawn", getRootElement(), setAllTeam ) 
addEventHandler ( "onClientLoginLoaded", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestAutologin", getRootElement(), setAllTeam ) 
  
function _setPlayerTeam() 
        setPlayerTeam ( player, team ) 
    setTimer ( function() 
        setPlayerTeam ( player, team ) 
    end, 5000, 1 ) 
end 
  
_setPlayerTeam() 

[Drakath]

I get this warning: WARNING: setteam\dteam.lua:28: Bad argument @ 'setPlayerTeam'

And still same problem team set when you die or connect but not log in. If you log in you are removed. Is there anyway to make player get into the team after log in? Event handler: onPlayerLogin didn't work.

[Guest Guest4401]

WARNING: setteam\dteam.lua:28: Bad argument @ 'setPlayerTeam'

It's obviously because player is nil.

[Drakath]

How do I fix it?

[Castillo]

function createAllTeamOnStart ( ) 
    AllTeam = createTeam ( "All", 0, 255, 0 ) 
    for index, player in ipairs ( getElementsByType ( "player" ) ) do 
        if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( player ) ), aclGetGroup ( "Everyone" ) ) then 
            setPlayerTeam ( player, AllTeam ) 
        end 
    end 
end 
addEventHandler ( "onResourceStart", resourceRoot, createAllTeamOnStart ) 
  
function setAllTeam ( ) 
    if isObjectInACLGroup ( "user.".. getAccountName ( getPlayerAccount ( source ) ), aclGetGroup ( "Everyone" ) ) then 
        setTimer ( setPlayerTeam, 2000, 1, source, AllTeam ) 
    end 
end 
addEventHandler ( "onPlayerLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerJoin", getRootElement(), setAllTeam ) 
addEventHandler ( "onPlayerSpawn", getRootElement(), setAllTeam ) 
addEventHandler ( "onClientLoginLoaded", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestLogin", getRootElement(), setAllTeam ) 
addEventHandler ( "onRequestAutologin", getRootElement(), setAllTeam ) 

[Drakath]

Thanks, it worked

[Castillo]

You're welcome.