problem with getting models

[Tete omar]

Hello ,

i made this script taking money from the passengers who entered and exited the specific vehicle models.

addEventHandler("onPlayerVehicleExit", getRootElement(), 
function(veh,sea) 
randomMoney = math.random( 50,200 ) 
    if ( getElementModel( veh ) == 420 or 428 ) then 
        if ( sea == 1 or 2 or 3 ) then 
            if ( getPlayerMoney( source ) >= tonumber( randomMoney ) ) then 
                takePlayerMoney( source, tonumber( randomMoney ) ) 
            end 
        end 
    end 
end) 

but unfortunately it takes the money from every vehicle model and every seat i enter and exit .. what's wrong ?.

[TAPL]

    if ( getElementModel( veh ) == 420 or 428 ) then 
        if ( sea == 1 or 2 or 3 ) then 

should be:

if (getElementModel(veh) == 420 or getElementModel(veh) == 428) then 
if (sea == 1 or sea == 2 or sea == 3) then 

[Tete omar]

yeah thx , i think tonumber is not needed becuase randomMoney is already a number right ?

[Guest Guest4401]

yeah thx , i think tonumber is not needed becuase randomMoney is already a number right ?

Yes, it's number.

[Tete omar]

Thanks karthik thanks tapl

[TAPL]

You should put randomMoney below this, so it won't make a random number every time you exit from vehicle, you only need it for 420 and 428.

if (sea == 1 or sea == 2 or sea == 3) then 

[Tete omar]

You should put randomMoney below this, so it won't make a random number every time you exit from vehicle, you only need it for 420 and 428.

if (sea == 1 or sea == 2 or sea == 3) then 

you mean like that ?

addEventHandler("onPlayerVehicleExit", getRootElement(), 
function(veh,sea) 
    if (getElementModel(veh) == 420 or getElementModel(veh) == 428) then 
        if (sea == 1 or sea == 2 or sea == 3) then 
            randomMoney = math.random( 50,200 ) 
            if ( getPlayerMoney( source ) >= randomMoney ) then 
                takePlayerMoney( source, randomMoney ) 
            end 
        end 
    end 
end) 

No i also think it's the same meaning than the other one, and thanks for the attention.

[TAPL]

it's will work in both way

but it's about performance (less CPU usage), also you should make it local anyway.