staff tag

[Stevenn]

i tried to make a staff tag script but it doesn't work..

function staffTag() 
local maxrange = 123 
    scx,scy = getScreenFromWorldPosition (x,y,z) 
    local x, y, z = getElementPosition ( localPlayer ) 
        local camX,camY,camZ = getCameraMatrix() 
            if scx and scy and getDistanceBetweenPoints3D(camX,camY,camZ,x,y,z+5) <= maxrange then  
        dxDrawText("Staff",x, y, z,tocolor(255,255,255,255),1.0,"bankgothic","left","top",false,false,false) 
        end 
end 
addEventHandler ( "onClientRender", root, staffTag )   

what is wrong?

[Guest Guest4401]

    scx,scy = getScreenFromWorldPosition (x,y,z) 
    local x, y, z = getElementPosition ( localPlayer ) 

You are trying to get screen position before getting the player's position.

If you didn't define x,y,z anywhere else, then these will be nil and give you an error.

[DiSaMe]

I'd rather like to know, what is right? You use x, y and z before getting the position of player, so you're passing nil values to getScreenFromWorldPosition. You also use those variables in dxDrawText, but they're coordinates in GTA world, and dxDrawText needs on-screen coordinates.