script error ~ I need Help

[Booo]

hi

my script have errors ...

can any one fix it please .!

  
  
  
  
function see() 
        local players = getElementsByType ( "player" ) 
            for k,v in ipairs(players) do 
            local seemark = getElementData(v,"seemark") 
                if seemark then 
                    return v 
                                          else 
                                       return false 
                end 
            end 
end 
  
function consoleCreateMarker ( thePlayer, commandName ) 
   if ( thePlayer ) then 
      local x, y, z = getElementPosition ( thePlayer )  
      setElementData(thePlayer,"seemark",true) 
      local theMarker = createMarker ( x + 2, y + 2, z, "cylinder", 1.5, 255, 255, 0, 170,see) 
   end 
end 
addCommandHandler ( "createmarker", consoleCreateMarker ) 
  
  
  
  
  
  
  
  

Edited April 25, 2012 by Guest

[BorderLine]

and what are the errors?? use /debugscript 3 nextime to show scriptings errors

[Booo]

and what are the errors?? use /debugscript 3 nextime to show scriptings errors

I can see the Marker, and I did not use Command : (

[Axel]

I fixed it for you and added some help:

function see() 
local players = getElementsByType ( "player" ) 
    for k,v in ipairs(players) do 
    local seemark = getElementData(v,"seemark") 
        if seemark == true then -- If the element data is true 
            return v 
            else 
            return false 
            end 
    end 
end 
  
function consoleCreateMarker ( thePlayer, commandName ) 
   if ( thePlayer ) then 
      local x, y, z = getElementPosition ( thePlayer ) 
      setElementData(thePlayer,"seemark","true") -- set it true 
      local theMarker = createMarker ( x + 2, y + 2, z, "cylinder", 1.5, 255, 255, 0, 170,see) 
   end 
end 
addCommandHandler ( "createmarker", consoleCreateMarker ) 

(tested)

[Booo]

I fixed it for you and added some help:

function see() 
local players = getElementsByType ( "player" ) 
    for k,v in ipairs(players) do 
    local seemark = getElementData(v,"seemark") 
        if seemark == true then -- If the element data is true 
            return v 
            else 
            return false 
            end 
    end 
end 
  
function consoleCreateMarker ( thePlayer, commandName ) 
   if ( thePlayer ) then 
      local x, y, z = getElementPosition ( thePlayer ) 
      setElementData(thePlayer,"seemark","true") -- set it true 
      local theMarker = createMarker ( x + 2, y + 2, z, "cylinder", 1.5, 255, 255, 0, 170,see) 
   end 
end 
addCommandHandler ( "createmarker", consoleCreateMarker ) 

(tested)

not work !!

[Axel]

Did u add it serverside? It works fine for me..

[Booo]

Did u add it serverside? It works fine for me..

yes serverside , but not work .!

[Axel]

Try now:

function see() 
local players = getElementsByType ( "player" ) 
    for k,v in ipairs(players) do 
    local seemark = getElementData(v,"seemark") 
        if seemark == "true" then -- If the element data is true 
            return v 
            else 
            return false 
            end 
    end 
end 
  
function consoleCreateMarker ( thePlayer, commandName ) 
   if ( thePlayer ) then 
      local x, y, z = getElementPosition ( thePlayer ) 
      setElementData(thePlayer,"seemark","true") -- set it true 
      local theMarker = createMarker ( x + 2, y + 2, z, "cylinder", 1.5, 255, 255, 0, 170,see) 
   end 
end 
addCommandHandler ( "createmarker", consoleCreateMarker ) 

[Kenix]

It's wrong.

In last argument you attach function

Here

local theMarker = createMarker ( x + 2, y + 2, z, "cylinder", 1.5, 255, 255, 0, 170,see) 

Also

if ( thePlayer ) then 

This condition not needed. This command triggered when you type this command. So if you type this command player is element in any case.

Better way

addCommandHandler ( 'createmarker',  
    function( uPlayer ) 
        local nX, nY, nZ = getElementPosition ( uPlayer ) 
        local uMarker = createMarker ( nX + 2, nY + 2, nZ, 'cylinder', 1.5, 255, 255, 0, 170, uPlayer ) 
    end 
) 

[Castillo]

What I understand is that you want to show the marker to the player who created it, if so you can use setElementVisibleTo.

function consoleCreateMarker ( thePlayer ) 
    local x, y, z = getElementPosition ( thePlayer ) 
    local theMarker = createMarker ( x + 2, y + 2, z, "cylinder", 1.5, 255, 255, 0, 170 ) 
    setElementVisibleTo ( theMarker, root, false ) -- Hide the marker to everyone. 
    setElementVisibleTo ( theMarker, thePlayer, true ) -- Show the marker to the player. 
end 
addCommandHandler ( "createmarker", consoleCreateMarker ) 

[Booo]

Yakuza.Real , Axel, Kenix, Solidsnake14

thx for help ,

Anyways I fixed my script ..

close topic

[Castillo]

You're welcome.

Topic locked.