Timer doesn't get killed

[BriGhtx3]

drugtimerrest = {} 
  
function timerAnzeigen() -- when I click the OK btn 
    guiSetVisible(Drugs_Window,false) 
    guiSetVisible(Create_Window,true) 
    restminuten = 20 
    guiSetText(Create_LBL_Timer, tonumber(restminuten).." Minuten") 
    drugtimerrest[getLocalPlayer()] = setTimer(updateTimerZeit,1000,0,getLocalPlayer()) 
end 
  
  
function updateTimerZeit(player) 
    restminuten = restminuten - 1 
    if restminuten <= 0 then 
        killTimer(drugtimerrest[player]) 
        drugtimerrest[player] = nil 
        guiSetVisible(Create_Window,false) 
    else 
        guiSetText(Create_LBL_Timer, tonumber(restminuten).." Minuten") 
    end 
end 
  
function abbrDr() -- when I click the cancel btn 
    killTimer(drugtimerrest[source]) 
    drugtimerrest[source] = nil 
end 
addEventHandler("onClientPlayerQuit",getRootElement(),abbrDr) 

My problem is that when I click the cancel btn, the gui gets invisible, but the timer seems not to get stopped.

When I click the OK Btn again, the timer gets even faster, and when I repeat it, the timer counts three times faster than normal...

The error after the "real" timer is finished is:

[b]Bad argument at killTimer [Expected lua-timer at argument 1, got nil][/b] 

This is the line :

killTimer(drugtimerrest[player]) 

[drk]

local tDrugTimer = { } 
  
function timerAnzeigen ( ) 
    guiSetVisible ( Drugs_Window, false ) 
    guiSetVisible ( Create_Window, true ) 
    time = 20 
    guiSetText ( Create_LBL_Timer, tonumber ( time ) .. ' Minuten' ) 
    tDrugTimer [ localPlayer ] = setTimer ( updateTimerZeit, 1000, 0, localPlayer ) 
end 
  
function updateTimerZeit ( player ) 
    time = time - 1 
    if ( time <= 0 ) then 
        killTimer ( tDrugTimer [ player ] ) 
        guiSetVisible ( Create_Window, false ) 
    else 
        guiSetText ( Create_LBL_Timer, tonumber ( time ) .. ' Minuten' ) 
    end 
end 
  
addEventHandler ( 'onClientPlayerQuit', root, 
    function ( ) 
        if ( isTimer ( tDrugTimer [ source ] ) ) then 
            tDrugTimer [ source ] = nil 
        end 
    end 
) 

Edited April 5, 2012 by Guest

[TAPL]

drugtimerrest[getLocalPlayer()] 

function abbrDr() -- when I click the cancel btn 
    killTimer(drugtimerrest[localPlayer]) 
    drugtimerrest[localPlayer] = nil 
end 
addEventHandler("onClientPlayerQuit",getRootElement(),abbrDr) 

Edited April 5, 2012 by Guest

[BriGhtx3]

@Draken its still the same

@Tapl that isn't the error, because I tried both.

[TAPL]

@Draken its still the same

@Tapl that isn't the error, because I tried both.

dude look at your code

function abbrDr() -- when I click the cancel btn 
    killTimer(drugtimerrest[localPlayer]) 
    drugtimerrest[localPlayer] = nil 
end 
addEventHandler("onClientPlayerQuit",getRootElement(),abbrDr) 

it's realy mess

it's client side! why you need to store local player element in table?

and killTimer when the localPlayer left? LOL!

[BriGhtx3]

So what should I change oO?

[TAPL]

somethings like this maybe

local drugtimerrest 
  
function timerAnzeigen() -- when I click the OK btn 
    guiSetVisible(Drugs_Window,false) 
    guiSetVisible(Create_Window,true) 
    restminuten = 20 
    guiSetText(Create_LBL_Timer, tonumber(restminuten).." Minuten") 
    if isTimer(drugtimerrest) then killTimer(drugtimerrest) end 
    drugtimerrest = setTimer(updateTimerZeit,1000,0) 
end 
  
function updateTimerZeit() 
    restminuten = restminuten - 1 
    if restminuten <= 0 then 
        if isTimer(drugtimerrest) then killTimer(drugtimerrest) end 
        guiSetVisible(Create_Window,false) 
    else 
        guiSetText(Create_LBL_Timer, tonumber(restminuten).." Minuten") 
    end 
end 

if you tell us what you trying to make we will be able to help you better

[BriGhtx3]

This works

Thanks

I just tried to make a simple timer for drug production.

[Kenix]

Not necessarily create table in client side for control timers. But if you create infinite timers in server side you should use tables and index for ex player or what you want for remove timer. So for example you create timer check something ( time playing, .. ). Example 10 players joined to server then created 10 timers . So you should clean timer if player quit ( in this case ) if you not create it your server ( will lag, because timers not killed ).