Changing skin +1

[Xeno]

I made a GUI and created a button on it called "->" and I made it so that when you press it, it changes you skin by 1, and I dont know why, but it doesnt work? Here is my script!

addEventHandler ( "onClientGUIClick", right, goRight, false ) 

  
  
function goRight(player) 
        local currentSkin = getElementModel (player) 
setElementModel (player, currentSkin +1) 
end 
  

[AeroXbird]

Try this:

  
function goRight(player) 
 local currentSkin = getElementModel (getLocalPlayer()) 
 setElementModel (getLocalPlayer(), currentSkin +1) 
end 
  

[Xeno]

Try this:

  
function goRight(player) 
 local currentSkin = getElementModel (getLocalPlayer()) 
 setElementModel (getLocalPlayer(), currentSkin +1) 
end 
  

That doesnt work

Thanks for replying though ;3

[AeroXbird]

Are you running this code server sided or clientsided?

[^Dev-PoinT^]

what the /debugscript 3 show?

[Xeno]

Are you running this code server sided or clientsided?

Client, and debug shows nothing

[Aibo]

i bet you'll have to check if the next skin ID is valid, for example:

function goRight(player) 
  local newSkin = getElementModel (localPlayer) + 1 
  while not setElementModel (localPlayer,newSkin) and newSkin < 288 do  
    newSkin = newSkin + 1  
  end 
end 

PS: you'll also have to check if new skin ID is not more than 288, cause it'll stuck in infinite loop otherwise (there are no valid skins after 288)

[AeroXbird]

Are you running this code server sided or clientsided?

Client, and debug shows nothing

as Aibo said, you have to check if the next skin is valid, if not keep continuing until you find a valid one.

also: try using this code serverside, changing skins and models is always best to do serversided, as clientside does not sync it for everyone, unless you want only the client to see the changes ( e.g. skin selection menu ).

[Xeno]

Its something wrong with the addEventHandler, it says that it expect a gui-element at argument 1.... But "right" is gui...

edit: read the wrong debug, lol, it says it neds a function at argument 3, but as I said before, argument 3 has a function in it...

[Aibo]

probably you call addEventHandler BEFORE you create the function itself.

you should define function first.

functions are the same as any variables — you can't use it until you define it.

you can't and don't do stuff like:

a = b + 1 
b = 10 

same with functions.

[Castillo]

Maybe is adding the event handler too soon?

[Xeno]

You were both right, I had it too soon. I feel very dumb, i seem to get stuck on the little easy errors -.-

Thank you all who helped me

[Castillo]

We all fail at something when learning, but that's how some people learn to fix their errors.