showElementHealth

[Klesh]

Hi to everyone, im doing a health script and this shows the health of the player on the scoreboard but some code is wrong and is not showing, here is the code:

Server-Side:

addEventHandler("onResourceStart", getResourceRootElement(getThisResource()),  
function() 
  exports.scoreboard:addScoreboardColumn("Health") 
end) 
  
function scoreboardHealthUpdate(a,b,c) 
  if getElementType(source) == "player" then 
    player = source 
  elseif getElementHealth(source) == "player" then 
    player = getElementHealth(source) 
     
  end 
  if player and player then  
    local damage = 0 
    if not b and not c then damage = a end 
    local health = math.floor((getElementHealth(player)-250-damage)/750*100) 
    setElementData(player, "Health", health.."%") 
  elseif player then 
    setElementData(player, "Health", "---")   
  end 
end 
  
addEventHandler("onPlayerDamage", getRootElement(), scoreboardHealthUpdate) 
addEventHandler("onPlayerSpawn", getRootElement(), scoreboardHealthUpdate) 
addEventHandler("onPlayerLogin", getRootElement(), scoreboardHealthUpdate) 
addEventHandler("onPlayerWasted", getRootElement(), scoreboardHealthUpdate) 
  

[Castillo]

I don't know why you do all that, it's useless.

addEventHandler("onResourceStart", getResourceRootElement(getThisResource()), 
function() 
  exports.scoreboard:addScoreboardColumn("Health") 
end) 
  
function scoreboardHealthUpdate() 
  if source and getElementType(source) == "player" then 
    local health = math.floor(getElementHealth(source)) 
    setElementData(source, "Health", health.."%") 
  end 
end 
  
addEventHandler("onPlayerDamage", getRootElement(), scoreboardHealthUpdate) 
addEventHandler("onPlayerSpawn", getRootElement(), scoreboardHealthUpdate) 
addEventHandler("onPlayerLogin", getRootElement(), scoreboardHealthUpdate) 
addEventHandler("onPlayerWasted", getRootElement(), scoreboardHealthUpdate) 

[Klesh]

Yes but is not useless, im making a complete server as you can see, but will be Freeroam like yours. "UFS"

[Castillo]

And what has that to do with this? I tested this in a freeroam server and works fine.

[Klesh]

Its only in-game the health player have and to know if this is hack or not:

Example: I kill someone with Hunter or grenades but i cant see the player with that you see the player health.

[Castillo]

Well...... then use the code I posted, it works fine.

[JR10]

Its only in-game the health player have and to know if this is hack or not:

Example: I kill someone with Hunter or grenades but i cant see the player with that you see the player health.

he is not talking about that your function had useless things, i think.

[Klesh]

Yes works fine, thanks a lot castillo and my error was here:

if player and player then 
    local damage = 0 
    if not b and not c then damage = a end 
    local health = math.floor((getElementHealth(player)-250-damage)/750*100) 
    setElementData(player, "Health", health.."%") 
  elseif player then 
    setElementData(player, "Health", "---")   
  end 
end 

The Fix:

function scoreboardHealthUpdate() 
  if source and getElementType(source) == "player" then 
    local health = math.floor(getElementHealth(source)) 
    setElementData(source, "Health", health.."%") 
  end 
end