Please help Bad argument @ 'isPedInVehicle'

[DeadReacen]

Hello gentlemen, everything okay?, My problem here is I can't remove the warning from the debug script

function Cavar(playerSource)
	if not isPedInVehicle(playerSource) then
		local Emprego = getElementData(playerSource, "Emprego") or "Desempregado"
		if Emprego == "Albañil" then
			if not isElement(saco[playerSource]) then
				if getPedWeapon(playerSource) == 6 then
					setTimer(function()
					end, 11300, 1)
				else
				end
			end
		end
	end
end
addEventHandler("onMarkerHit", cavar, Cavar)
--For scripter safety I had to delete lines

WARNING: server.lua:48: Bad argument @ 'isPedInVehicle' [Expected ped at argument 1, got vehicle]

   if not playerSource  then  
     return 
   end 
   if isPedInVehicle(playerSource) then
--use these functions but they don't work

The truth is I did everything to try but something else does not occur to me.

I hope you have an idea, I will thank you with all my heart

[vicisdev]

The event onMarkerHit is triggered anytime an element hits the marker, not only when a player hits a marker. Turns out the vehicle is also an element and usually when a player runs over a marker driving a vehicle the vehicle element hits the marker before the player element.

You have two options:

1. Use onPlayerMarketHit instead. Note it's not a drop in replacement, you'll have to change your code to work with onPlayerMarkerHit
2. At the very top of the Cavar function, check for the element type before executing any action

local function Cavar(hitElement)
  if getElementType(hitElement) ~= "player" then
    return
  end
  
  -- Here you place your current code
end

 

Excuse me to give you a general tip around programming. Avoid nesting to much if statements, always check by the failure condition and return your function.

Dont:

-- Evite muitos IFs encadeados!

local function Cavar(hitElement)
  if getElementType(hitElement) == "player" then
    if not isPedInVehicle(hitElement) then
      --- code ...
    end
  end
end

 

Do:

-- Muito mais elegante

local function Cavar(hitElement)
  if getElementType(hitElement) ~= "player" or
     isPedInVehicle(hitElement)
  then
   	return
  end
  
  -- code ...
end

 

You can find reference for onMarkerHit, onPlayerMarkerHit and getElementType on the official wiki.
 

Edited December 13, 2021 by vicisdev

[DeadReacen]

34 minutes ago, vicisdev said:

The event onMarkerHit is triggered anytime an element hits the marker, not only when a player hits a marker. Turns out the vehicle is also an element and usually when a player runs over a marker driving a vehicle the vehicle element hits the marker before the player element.

You have two options:

1. Use onPlayerMarketHit instead. Note it's not a drop in replacement, you'll have to change your code to work with onPlayerMarkerHit
2. At the very top of the Cavar function, check for the element type before executing any action

local function Cavar(hitElement)
  if getElementType(hitElement) ~= "player" then
    return
  end
  
  -- Here you place your current code
end

 

Excuse me to give you a general tip around programming. Avoid nesting to much if statements, always check the failure condition and return your function.

Dont:

-- Evite muitos IFs encadeados!

local function Cavar(hitElement)
  if getElementType(hitElement) ~= "player" then
    if not isPedInVehicle(hitElement) then
      --- code ...
    end
  end
end

 

Do:

-- Muito mais elegante

local function Cavar(hitElement)
  if getElementType(hitElement) ~= "player" or
     isPedInVehicle(hitElement)
  then
   	return
  end
  
  -- code ...
end

 

You can find reference for onMarkerHit, onPlayerMarkerHit and getElementType on the official wiki.
 

I can't believe it for hours trying to fix it and I couldn't, Thank you very much and what you told me I'll take into account.

Fixed issue Close Post