onClientPlayerVoiceStart

fairyoggy · July 24, 2019

Made a label appear with a player's nickname who say in voice chat.

But if you use such code. it will be bad when they talk a lot of players.

How can I make sure that when several people speak at the same time they create several lines with their names?

vv = guiCreateLabel(17,170,170,30,"",false)
guiSetVisible(vv,false)
addEventHandler ( "onClientPlayerVoiceStart", root,
	function()
		local name = getPlayerName(getLocalPlayer())
		local p_id = getElementData ( source, "ID" )
		voicePlayers[source] = true
		guiSetText(vv,"Talk: "..name.." ["..p_id.."]")
		guiSetFont(vv,myfont)
		guiSetVisible(vv,true)
	end
)

addEventHandler ( "onClientPlayerVoiceStop", root,
	function()
		voicePlayers[source] = nil
		guiSetVisible(vv,false)
	end
)

In the screenshot, I marked the numbers. This, for example, if 4 players are talking at the same time

HassoN · July 24, 2019

Try this:

local playersUsingMic = {}
local x, y = guiGetScreenSize ( )
local sx, sy = 1600, 900

function onStartVoiceChat()
	local p_id = getElementData (source, "ID") or "0"
	table.insert(playersUsingMic, {source, p_id})
end
addEventHandler("onClientPlayerVoiceStart", root, onStartVoiceChat)

function onStopVoiceChat()
	for i, v in ipairs(playersUsingMic) do
		if (v[1] == source) then
			table.remove(playersUsingMic, i)
		end
	end
end
addEventHandler("onClientPlayerVoiceStop", root, onStopVoiceChat)

function drawText()
	if (#playersUsingMic > 0) then
		for i, v in ipairs(playersUsingMic) do
			dxDrawText("Talk: "..getPlayerName(v[1]).." ["..v[2].."]", x * (27/sx), i*30 + y * (341/sy), x * (294/sx), i*30 + y * (376/sy), tocolor(255, 255, 255, 255), 1.00, "default-bold", "left", "top", false, false, false, false, false)
		end
	end
end
addEventHandler("onClientRender", root, drawText)

Edited July 24, 2019 by HassoN

fairyoggy · July 25, 2019

1 hour ago, HassoN said:

Try this:


local playersUsingMic = {}
local x, y = guiGetScreenSize ( )
local sx, sy = 1600, 900

function onStartVoiceChat()
	local p_id = getElementData (source, "ID") or "0"
	table.insert(playersUsingMic, {source, p_id})
end
addEventHandler("onClientPlayerVoiceStart", root, onStartVoiceChat)

function onStopVoiceChat()
	for i, v in ipairs(playersUsingMic) do
		if (v[1] == source) then
			table.remove(playersUsingMic, i)
		end
	end
end
addEventHandler("onClientPlayerVoiceStop", root, onStopVoiceChat)

function drawText()
	if (#playersUsingMic > 0) then
		for i, v in ipairs(playersUsingMic) do
			dxDrawText("Talk: "..getPlayerName(v[1]).." ["..v[2].."]", x * (27/sx), i*30 + y * (341/sy), x * (294/sx), i*30 + y * (376/sy), tocolor(255, 255, 255, 255), 1.00, "default-bold", "left", "top", false, false, false, false, false)
		end
	end
end
addEventHandler("onClientRender", root, drawText)

It works like I wanted, BUT if 1 player presses the microphone 2 times, or will press and press several times, there will be such a problem

and if you let go of the microphone button, the upper inscription will remain, and the lower one will disappear

How to fix it? For one player, the inscription must be one

SrSampaio32112321 · July 25, 2019

1 hora atrás, slapz0r disse:

Edited July 25, 2019 by MrShadows
Estava faltando algo

fairyoggy · July 25, 2019

10 minutes ago, MrShadows said:

Try this again ..

Your code is no different from the previous one. In addition to errors

SrSampaio32112321 · July 25, 2019

1 hora atrás, slapz0r disse:

locais playersUsingMic={}

local x,y= guiGetScreenSize ()

sx local , sy = 1600 , 900

function onStartVoiceChat ()

p_id local = getElementData ( origem , "ID" ) ou "0"

mesa . insert (playersUsingMic,{source,p_id})

fim

addEventHandler (" onClientPlayerVoiceStart ",root,onStartVoiceChat)

function onStopVoiceChat ()

para eu , v em ipairs ( playersUsingMic ) fazer

se ( v [ 1 ] == fonte ) então

mesa . remove (playersUsingMic,i)

fim

fim

fim

addEventHandler (" onClientPlayerVoiceStop ",root,onStopVoiceChat)

function drawText ()

if (# playersUsingMic > 0 ), então

para eu , v em ipairs ( playersUsingMic ) fazer

dxDrawText ("Talk:".. getPlayerName (["..v[1] .."] ".." ["..v[2] .."] ",x*(27/sx),i*30+y*(341/sy),x*(294/sx),i*30+y*(376/sy), tocolor( 255 , 255 , 255 , 255 ), 1,00 , "default-bold" , "esquerda" , "top" , falso , falso , falso , falso , falso )

fim

fim

fim

addEventHandler (" onClientRender ",root,drawText)

Edited July 25, 2019 by MrShadows
Estava faltando algo

fairyoggy · July 25, 2019

4 minutes ago, MrShadows said:

dxDrawText ("Talk:".. getPlayerName (["..v[1] .."]" .."["..v[2] .."]",x*(27/sx),i*30+y*(341/sy),x*(294/sx),i*30+y*(376/sy), tocolor ( 255 , 255 , 255 , 255 ), 1,00 , "default-bold" , "esquerda" , "top" , falso , falso , falso , falso , falso )

What do you have with a line?!

SrSampaio32112321 · July 25, 2019

Have you tried this one?

fairyoggy · July 25, 2019

1 minute ago, MrShadows said:

Have you tried this one?

Yes, but as far as I understand, this is not properly done.

SrSampaio32112321 · July 25, 2019

Sorry for the mistake then... I will try to solve this later .. i use python script , not Lua, sorry ...

Edited July 25, 2019 by MrShadows

fairyoggy · July 25, 2019

9 hours ago, slapz0r said:

It works like I wanted, BUT if 1 player presses the microphone 2 times, or will press and press several times, there will be such a problem

and if you let go of the microphone button, the upper inscription will remain, and the lower one will disappear

How to fix it? For one player, the inscription must be one

up

HassoN · July 25, 2019

9 hours ago, slapz0r said:

It works like I wanted, BUT if 1 player presses the microphone 2 times, or will press and press several times, there will be such a problem

and if you let go of the microphone button, the upper inscription will remain, and the lower one will disappear

How to fix it? For one player, the inscription must be one

Sorry for late response, I was sleeping.

local playersUsingMic = {}
local x, y = guiGetScreenSize ( )
local sx, sy = 1600, 900

function onStartVoiceChat()
	local myIndex = getMyValue(source)
	if (not myIndex or not playersUsingMic[myIndex]) then
		local p_id = getElementData (source, "ID") or "0"
		table.insert(playersUsingMic, {source, p_id})
	end
end
addEventHandler("onClientPlayerVoiceStart", root, onStartVoiceChat)

function onStopVoiceChat()
	for i, v in ipairs(playersUsingMic) do
		if (v[1] == source) then
			table.remove(playersUsingMic, i)
		end
	end
end
addEventHandler("onClientPlayerVoiceStop", root, onStopVoiceChat)

function drawText()
	if (#playersUsingMic > 0) then
		for i, v in ipairs(playersUsingMic) do
			dxDrawText("Talk: "..getPlayerName(v[1]).." ["..v[2].."]", x * (27/sx), i*30 + y * (341/sy), x * (294/sx), i*30 + y * (376/sy), tocolor(255, 255, 255, 255), 1.00, "default-bold", "left", "top", false, false, false, false, false)
		end
	end
end
addEventHandler("onClientRender", root, drawText)


function getMyValue(player)
	for i, v in ipairs(playersUsingMic) do
		if v[1] == player then
			return i
		end
	end
end

Edited July 25, 2019 by HassoN

fairyoggy · July 25, 2019

13 hours ago, HassoN said:

Sorry for late response, I was sleeping.


local playersUsingMic = {}
local x, y = guiGetScreenSize ( )
local sx, sy = 1600, 900

function onStartVoiceChat()
	local myIndex = getMyValue(source)
	if (not myIndex or not playersUsingMic[myIndex]) then
		local p_id = getElementData (source, "ID") or "0"
		table.insert(playersUsingMic, {source, p_id})
	end
end
addEventHandler("onClientPlayerVoiceStart", root, onStartVoiceChat)

function onStopVoiceChat()
	for i, v in ipairs(playersUsingMic) do
		if (v[1] == source) then
			table.remove(playersUsingMic, i)
		end
	end
end
addEventHandler("onClientPlayerVoiceStop", root, onStopVoiceChat)

function drawText()
	if (#playersUsingMic > 0) then
		for i, v in ipairs(playersUsingMic) do
			dxDrawText("Talk: "..getPlayerName(v[1]).." ["..v[2].."]", x * (27/sx), i*30 + y * (341/sy), x * (294/sx), i*30 + y * (376/sy), tocolor(255, 255, 255, 255), 1.00, "default-bold", "left", "top", false, false, false, false, false)
		end
	end
end
addEventHandler("onClientRender", root, drawText)


function getMyValue(player)
	for i, v in ipairs(playersUsingMic) do
		if v[1] == player then
			return i
		end
	end
end

The main thing that you could help, thanks!

Another question, need to make this inscription appear within 15 meters.

I mean, now any player will click on the microphone button and it will display what he says BUT i need

so that it is displayed within 15 meters of the player.

For example, on the server 3 people. 2 players are together and the third is in a different place.

If a third player will talk, the first and second should not see the inscription because they are far from the player.

and the first and second players will see each other's inscriptions.

I hope I correctly explained what I need.

Can you help me with this?

HassoN · July 25, 2019

27 minutes ago, slapz0r said:

The main thing that you could help, thanks!

Another question, need to make this inscription appear within 15 meters.

I mean, now any player will click on the microphone button and it will display what he says BUT i need

so that it is displayed within 15 meters of the player.

For example, on the server 3 people. 2 players are together and the third is in a different place.

If a third player will talk, the first and second should not see the inscription because they are far from the player.

and the first and second players will see each other's inscriptions.

I hope I correctly explained what I need.

Can you help me with this?

Try this

local playersUsingMic = {}
local x, y = guiGetScreenSize ( )
local sx, sy = 1600, 900

function onStartVoiceChat()
	local x, y, z = getElementPosition(source)
	local x2, y2, z2 = getElementPosition(localPlayer)
	local distance = getDistanceBetweenPoints3D(x, y, z, x2, y2, z2)
	if (distance <= 15) then
		local myIndex = getMyValue(source)
		if (not myIndex or not playersUsingMic[myIndex]) then
			local p_id = getElementData (source, "ID") or "0"
			table.insert(playersUsingMic, {source, p_id})
		end
	end
end
addEventHandler("onClientPlayerVoiceStart", root, onStartVoiceChat)

function onStopVoiceChat()
	for i, v in ipairs(playersUsingMic) do
		if (v[1] == source) then
			table.remove(playersUsingMic, i)
		end
	end
end
addEventHandler("onClientPlayerVoiceStop", root, onStopVoiceChat)

function drawText()
	if (#playersUsingMic > 0) then
		for i, v in ipairs(playersUsingMic) do
			dxDrawText("Talk: "..getPlayerName(v[1]).." ["..v[2].."]", x * (27/sx), i*30 + y * (341/sy), x * (294/sx), i*30 + y * (376/sy), tocolor(255, 255, 255, 255), 1.00, "default-bold", "left", "top", false, false, false, false, false)
		end
	end
end
addEventHandler("onClientRender", root, drawText)


function getMyValue(player)
	for i, v in ipairs(playersUsingMic) do
		if v[1] == player then
			return i
		end
	end
end

fairyoggy · July 25, 2019

12 minutes ago, HassoN said:

Try this


local playersUsingMic = {}
local x, y = guiGetScreenSize ( )
local sx, sy = 1600, 900

function onStartVoiceChat()
	local x, y, z = getElementPosition(source)
	local x2, y2, z2 = getElementPosition(localPlayer)
	local distance = getDistanceBetweenPoints3D(x, y, z, x2, y2, z2)
	if (distance <= 15) then
		local myIndex = getMyValue(source)
		if (not myIndex or not playersUsingMic[myIndex]) then
			local p_id = getElementData (source, "ID") or "0"
			table.insert(playersUsingMic, {source, p_id})
		end
	end
end
addEventHandler("onClientPlayerVoiceStart", root, onStartVoiceChat)

function onStopVoiceChat()
	for i, v in ipairs(playersUsingMic) do
		if (v[1] == source) then
			table.remove(playersUsingMic, i)
		end
	end
end
addEventHandler("onClientPlayerVoiceStop", root, onStopVoiceChat)

function drawText()
	if (#playersUsingMic > 0) then
		for i, v in ipairs(playersUsingMic) do
			dxDrawText("Talk: "..getPlayerName(v[1]).." ["..v[2].."]", x * (27/sx), i*30 + y * (341/sy), x * (294/sx), i*30 + y * (376/sy), tocolor(255, 255, 255, 255), 1.00, "default-bold", "left", "top", false, false, false, false, false)
		end
	end
end
addEventHandler("onClientRender", root, drawText)


function getMyValue(player)
	for i, v in ipairs(playersUsingMic) do
		if v[1] == player then
			return i
		end
	end
end

OK, everything is great

Another caveat, how to deal with this?

For example, you are 14 meters from the player, he pressed a button - you see his inscription - everything is fine

If he presses the button, and at that time you will have another 5 meters from him, that is, there will already be 19 meters

You will have an inscription (this is on the condition that he has the button still clamped), can it be done so when the player has the button clamped and you go beyond 15 meters the inscription disappears?

HassoN · July 25, 2019

Explain more, I don't get it.

fairyoggy · July 25, 2019

5 minutes ago, HassoN said:

Explain more, I don't get it.

For example, you are 14 meters away from the player, he will press the button - you will see the inscription - it's fine

you are 16 meters away from the player, he will press the button - the inscription you will not see - it's fine

The player presses (and holds) the button (at this time you are 16 meters away) - the inscription can't see

The player does not release the button, and at this time you are go to the player (and now the distance is already 14 meters)

The player did not release the button and you do not see the inscription. Of course, if the player releases the button and presses again - you will see the inscription. But we are talking about the holding button.

HassoN · July 26, 2019

59 minutes ago, slapz0r said:

For example, you are 14 meters away from the player, he will press the button - you will see the inscription - it's fine

you are 16 meters away from the player, he will press the button - the inscription you will not see - it's fine

The player presses (and holds) the button (at this time you are 16 meters away) - the inscription can't see

The player does not release the button, and at this time you are go to the player (and now the distance is already 14 meters)

The player did not release the button and you do not see the inscription. Of course, if the player releases the button and presses again - you will see the inscription. But we are talking about the holding button.

I've checked the available functions/events but I couldn't find anything useful for your case.

fairyoggy · July 26, 2019

4 minutes ago, HassoN said:

I've checked the available functions/events but I couldn't find anything useful for your case.

no problems, thanks!

HassoN · July 26, 2019

14 minutes ago, slapz0r said:

no problems, thanks!

You're welcome

N3xT · July 26, 2019

You can use onClientRender for this, and check his position

Edited July 26, 2019 by N3xT

HassoN · July 26, 2019

3 minutes ago, N3xT said:

You can use onClientRender for this, and check his position

Getting player's position with onClientRender is totally inefficient for the server's performance, you could've suggested something a little bit better like setting a timer. But either ways, you can't use either of them because there's no function which checks if X player is using his mic.

N3xT · July 26, 2019

You got it wrong. using onClientRender correctly won't harm the server performance at all there's a lot of scripts using the same method, for example, race name tags and there's more and more

also, you can use variables with onClientPlayerVoiceStart & onClientPlayerVoiceStop to determine if the player using his microphone or not, however, you don't need this because you've already inserted the players using their microphones into a table so you can use this too.

Edited July 26, 2019 by N3xT

HassoN · July 26, 2019

2 minutes ago, N3xT said:

You got it wrong. using onClientRender correctly won't harm the server performance at all there are a lot of scripts using the same method, for example, race name tags and there's more and more

also, you can use variables with onClientPlayerVoiceStart & onClientPlayerVoiceStop to determine if the player using his microphone or not, however, you don't need this because you've already inserted the players using their microphones into a table so you can use this too.

Race name tags? do you mean dx functions? Then onClientRender is obviously a must.

I am trying to advise the topic's owner to the least inefficient method. So I still believe using onClientRender to get someone's position is totally unnecessary and could be simply replaced by a timer.

About your suggestion, that could be a good idea but in my tables, players get added to the table only if they are close to the local player so you can't actually use them to check because in this case, players don't get added to the table in the first place because they keep holding the button.

Maybe adding another table which includes all players who are using mics (even if they are far away) then using a timer to check if someone from that table gets close enough to the local player so we add him to the 2nd table (which is used to show close players) should work.

N3xT · July 27, 2019

6 hours ago, HassoN said:

Race name tags? do you mean dx functions? Then onClientRender is obviously a must.

I am trying to advise the topic's owner to the least inefficient method. So I still believe using onClientRender to get someone's position is totally unnecessary and could be simply replaced by a timer.

About your suggestion, that could be a good idea but in my tables, players get added to the table only if they are close to the local player so you can't actually use them to check because in this case, players don't get added to the table in the first place because they keep holding the button.

Maybe adding another table which includes all players who are using mics (even if they are far away) then using a timer to check if someone from that table gets close enough to the local player so we add him to the 2nd table (which is used to show close players) should work.

I'm not talking about dx functions, a lot of developers thinks that using anything but dx functions inside a render is wrong and might harm your server and things like that, I'm not saying that's true nor false. depends on the way you use the render but do you think using a function like getElementPosition inside a render is wrong? totally not.

when I told you race nametags are using the same method I meant getting the position of the player and calculating the scale of the text and we've been using it for years now and I've never seen anybody complain about it, you can check race gamemode and you'll get the full picture of what I'm talking about.

and yeah, the same goes for timers.

onClientPlayerVoiceStart

Recommended Posts

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Link to comment

Create an account or sign in to comment

Create an account

Sign in

Recently Browsing 0 members