Jump to content

Arran

MTA Contributors
  • Posts

    590
  • Joined

  • Last visited

Posts posted by Arran

  1. "(If your name is missing or you want to change your entry above, please let us know on Discord!)" -  But which channel on discord? Asking cause I donated a few months back and never got an email afterwards, I emailed the address the paypal account uses about it and never got a reply.

  2. This sounds like a really big project and you seem to like major projects, doing loads of work on them, but then lose interest near the end. Which is a real shame that so much talented work goes to waste like MTA: Eir. There are much smaller issues that can have a big benefit to all players, like how client FPS is so low. I traced one cause of low client FPS to sounds: https://github.com/multitheftauto/mtasa-blue/issues/1067 Surely finding the root cause (see the newest comment posted on the issue as to how we might be able to do that) and then fixing it could be a fraction of the work of some big project like this, but would benefit every single of the tens of thousands of MTA players.

  3. After watching mtaqa Twitch stream hosted by @Woovie which included some time spent playing on CIT I realised that there are some obvious flaws which never get reported on our forum especially things that affect new players as our forum is unlikely to ever get feedback from brand new players.

    From watching Woovie's stream these problems were pointed out and have been fixed:

    • Tutorial UI having a line that wasn't straight which was what he switched to full screen mode to try fix.
    • Doubled the strength of the marker shader texture so it's more visible.
    • Made the text when entering certain markers much more visible.

    So I thought that rather than using this topic to advertise, it would be better to receive feedback from anyone whose just tried the server out. This topic isn't for you to rant about some nonsense made up by dramatists.

  4. Currently to test a pull request:

    1. 4 minutes to download (appveyor download today was only going 400 kb/s so takes almost 4 minutes to download)

    2. 1 minute to copy all the files into the MTA installation.

    3. 30 seconds to modify the meta.xml each time.

    4. 1 minute to launch client and server and join the server.

    So at the moment it takes over 6 minutes just to get the PR build launched to test.

    Can't PR's all just get merged into a testing branch so can test all PR's in 1 go? This is especially important because if a PR is tested 1 by 1 we're unlikely to notice any rare bug in the PR that could take hours of playing random stuff to come up.

  5. " i got rights from Brian and arran " - Uhh no you haven't? Some scripts got leaked many years ago and many servers have been using them for years. MTA team are not responsible for dealing with failures in trust by server admins. Also they just decompiled some client side scripts which seems to have been done many years ago. And if a server has to use stolen scripts they will obviously never be a server worth playing on.

  6. I joined discord.

    I've already tested the only PR I can see (fast_lookup_byindex) on nightlytest and posted the results of that already. I'm aware that I can download them on github at the checks => appveyor => details => artifacts.

    @qaisjp how about some tags on PR's like a "needs testing" tag so once an MTA developer has looked at the code and would be happy to merge it if it's been tested add the "needs testing" tag and then someone (probably me) can test it and then post back the test results and I guess then I could change the tag to "tested".

  7. On 10/11/2018 at 06:17, ShayF said:

    MTA is open-source, which means that anyone can contribute

    Anyone can contribute as you can see here: https://github.com/multitheftauto/mtasa-blue/pulls

    Unfotunately it seems that not enough people are given commit access to merge pull requests which is preventing all these pull requests getting merged. I counted 13 different people in those 42 pending pull requests who do not have access to merge pull requests who may want to be doing even more pull requests if they got merged. I made source patches in the past but I didn't feel like doing more until the existing ones had been looked at and by the time they did get looked at I'd lost interest / forgot what I'd learned. The same could apply to these people, they might want to do more but they don't see the point if even their already done stuff may never get merged.

    I'm not really sure what the problem is because correct me if I'm wrong but an MTA dev just needs to briefly look at the changed code to make sure it's not dodgy and then the community like me can spend the time doing the testing? Which I would do and have done. Or at least trust a few more people to make commits like the ones who have submit the most PR's.

    On 10/11/2018 at 06:17, ShayF said:

    use their modified version of MTA. Correct?

    No because obviously you could put cheats in your version. You can only use a modified / a custom build version of MTA on modified / custom built versions of the server.

  8. On 01/09/2018 at 10:08, PolskiSebek12 said:

    that been 5 years ago, do now it is possible ?

    MTA server has 4 threads: Main, sync, raknet and database. Although this doesn't mean it could completely use up 100% of a CPU's power, it doesn't need to because there are no servers popular enough to be affected by this. The record for online players on 1 server is 1400 and that server did not even lag during that insane peak, this was thanks to all the effort ccw made optimizing MTA server and the semi multi threaded support it has. Also efficient scripts help which again is thanks to ccw's performancebrowser which allows scripters to see what needs optimizing.

    It is client performance that is much more of a problem now. Many of us have modern PC's that can play GTA V on high and have stable 60 FPS yet on MTA servers with many objects, vehicles and players around we can get as low as 30 FPS. Those with older PC's don't stand a chance.

  9. 5 hours ago, Jusonex said:

    No, I meant the specific pull request e.g. https://github.com/multitheftauto/mtasa-blue/pull/186

    Ahh, I've tried one and my client crashes when joining the local server, gonna try another, 79 MB from appveyor.com takes 5 minutes. (Was trying "Add setElementCollidableWithType #181")

    Also I just realised there isn't actually a 1.6 section on nightly.multitheftauto.com so does that mean master is 1.5.5? As someone whose been testing next release version since 1.0 it doesn't seem right that there is no 1.6 because... well all the major additions that MTA has had in the past, needed it so we could test them and for when there's non backward compatible changes.

    Second attempt I'm now getting "Multi Theft Auto has not been installed properly, please reinstall." (Was trying "Added dynamic ped ID allocating(based on lopezloo pull request) #151")

  10. 2 hours ago, Necktrox said:

    You know that I did Pull Request testing recently and I am planing to do more?

    I've been checking MTA commits multiple times a day for about 8 years, you know I updated wiki and mantis regarding those merged pull requests? ;)

    If you're planning on merging more that's great, just tell me what I can do to help, such as if there was a way for me to test the pull requests.

  11. Some pull requests are over a year old, there's 23 pending, and a lot of them have this tag: "pr:needs-testing" I would be happy to test these if there was a way to test them without having to go to all the effort of compiling my own build.

    Correct me if I'm wrong but 'master' is 1.6 and therefore basically all pull requests could be merged to master right now (or make a branch where all pull requests are merged to) and then we'd be able to test it all with the 1.6 nightly and then the whole community would have the ability to test all pull requests, then we can confirm whether or not the pull requests work. 1.6 is a long way off so there'd be plenty of time for any bugs to get discovered and if we're given a few weeks notice before a 1.6 release we can do general testing to see if any random bugs have popped up.

    A lot more pull requests might actually get made if they got merged, back when I made some source pathces, it was demotivating to see my patches get ignored, then I just lost interest. The people with pending pull requests from months ago are probably feeling the same thing.

    To be honest, all the pull requests combined could actually be good enough for a new release especially when there's "Added dynamic ped ID allocating" and if there was dynamic object ID allocating I'd be begging for 1.6 to get released. All you guys gotta do is check their code to make sure it looks legit, then I can do all the ingame testing.

    • Like 2
  12. Last week MTA had 392,000 unique players, 2 months ago it was 327,000. This is a 19% increase in players in just 2 months.

    Does anyone have any idea as to what could have caused this SIXTY FIVE THOUSAND person increase in people playing MTA?!?!?!

    • Like 2
  13. GTA 4? You've got to be joking. Why the hell would anyone waste their time making something for crappy GTA 4 that nobody plays any more when GTA 5 has been out for years... There already is a multiplayer mod for GTA 4 and I just checked how many people are playing it right now... 5 people.

    • Like 2
  14. You're missing 'arg'.

    'arg' is a predefined Lua variable in functions which use '...' as an argument. Example:

    crun function a(...) outputChatBox(tostring(arg.n)) end a(10, 20, 30) -- "3" (arg.n returns 3 because there were 3 arguments in ...)

    crun function a(...) outputChatBox(tostring(arg[2])) end a(10, 20, 30) -- "20" (arg[2] returns 20 because the second argument in ... is 20.)

  15. Is it just existing MTA internal functions that you want documenting? I thought that visual studio already has features which show you function lists and their parameters. The main thing that stopped me being able to contribute more was when it comes to doing something new, I wouldn't have the slightest clue where to start so for me the most useful documentation would be explaining how to do new things which I guess involves memory hacks.

    Like you said, this is something that is done over the long term so there's no reason why you can't get the ball rolling by getting a list of all functions and there parameters and starting some wiki pages with this basic information and then include stuff like "Please can a developer who understands this explain this" and then eventually some information might get added to it.

    • Like 1
  16. 10 hours ago, xTravax said:

    I was just waiting for someone to say this.

    "We are MTA Team, we have a huge ego, you should oblige us, screw you if you have requests, your request can be done in a very harder way, so why should MTA Team make it easier for you?" - This is exact thing what you're portraying right now. If you'd have read my post, you'd have seen that I've said that it could be done over time, not instantly right now. Throughout time file by file, or document by document could be documented. Those 17 pull requests are mostly sitting there, some of them get included over time. There would be way more pull requests if there was more documentation about the code. Right now, to become good at contributing what you'd have to do is spend few months learning, testing, experimenting how everything works, all by yourself, and probably wait for hours/days/weeks for someone to even reply to you how to do certain thing to code when you have no idea how to accomplish something. Even with Discord this takes that long.

    What do you have now, like 3-4 contributors and 2-3 MTA Staff members working on code, you really find that number of people to be so great? With bigger documentation that number would easily be able to increase, perhaps even to 20-30. This game might be old as well but it's still being played by a lot of people, and more contributors could mean that complex stuff such as custom animations, custom IDs and such could be much easily and faster implemented. I'm waiting for someone's reply which will say how I'm wrong and that it's just a waste of time (again).

    MTA is open source... What is stopping YOU from documenting this stuff?

    Here's some documentation: https://wiki.multitheftauto.com/wiki/Coding_info

    And guess who wrote that page? I did. Am I an MTA developer? No. I have managed to make documentation and contribute actual working source patches yet the C++ knowledge that I have could be learned within 1 day so what is your excuse for not looking at the source code and documenting it? Because you didn't make that source code? And you really think whoever wrote that is even around now to document it or anyone can even remember what exactly was written by who when some of this source is 10 years old?

    • Like 1
  17. As I post this there are 17 open pull requests. MTA developers shouldn't waste time documenting stuff when there's open pull requests made by people who didn't need any documentation that need adding. Even I managed to make a pull request and have made some other contributions in the past and I did that with existing documentation and with only very basic C++ knowledge, a lot can be done by just looking at, copying, modifying existing code.

    I Just realised my pull request has been ignored for 5 months even though developers already gave me tips to improve it and I did all the improvements, the code is flawless but un-added :/ it's really demotivating, I'd probably have contributed more if my source patches had have been added sooner and perhaps other potential contributors are getting put off too because why would you spend time making a second patch when your first one might never even get added?

    • Like 1
  18. On 27/12/2016 at 11:26 PM, Jusonex said:

    However, this would restrict the debug capabilities a lot as debug information are stripped as well (so you'd get bad error messages without script name and line).

    I use luac.multitheftauto.com and get script name and lines when a client has a debug message.

    I guess it depends what settings you have set here: https://luac.multitheftauto.com/api/

    I don't think there's any need for this suggestion because if you use a batch file all you have to do is drag and drop the .lua into the .bat and within seconds your .luac is updated.

    • Like 1
×
×
  • Create New...